Skip to content

Conversation

kparzysz
Copy link
Contributor

DECLARE REDUCTION is now handled by the generic code, and the special handling no longer applies.

DECLARE REDUCTION is now handled by the generic code, and the special
handling no longer applies.
@kparzysz kparzysz requested review from tblah and Stylie777 September 30, 2025 15:08
@llvmbot llvmbot added flang Flang issues not falling into any other category flang:parser labels Sep 30, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 30, 2025

@llvm/pr-subscribers-flang-parser

Author: Krzysztof Parzyszek (kparzysz)

Changes

DECLARE REDUCTION is now handled by the generic code, and the special handling no longer applies.


Full diff: https://github.com/llvm/llvm-project/pull/161390.diff

1 Files Affected:

  • (modified) flang/include/flang/Parser/openmp-utils.h (-2)
diff --git a/flang/include/flang/Parser/openmp-utils.h b/flang/include/flang/Parser/openmp-utils.h
index b8f3559097750..f761332c9cfd7 100644
--- a/flang/include/flang/Parser/openmp-utils.h
+++ b/flang/include/flang/Parser/openmp-utils.h
@@ -39,7 +39,6 @@ struct ConstructId {
   }
 
 MAKE_CONSTR_ID(OpenMPDeclarativeAllocate, D::OMPD_allocate);
-MAKE_CONSTR_ID(OpenMPDeclareReductionConstruct, D::OMPD_declare_reduction);
 MAKE_CONSTR_ID(OpenMPExecutableAllocate, D::OMPD_allocate);
 
 #undef MAKE_CONSTR_ID
@@ -92,7 +91,6 @@ struct DirectiveNameScope {
       if constexpr (std::is_base_of_v<OmpBlockConstruct, T>) {
         return std::get<OmpBeginDirective>(x.t).DirName();
       } else if constexpr (std::is_same_v<T, OpenMPDeclarativeAllocate> ||
-          std::is_same_v<T, OpenMPDeclareReductionConstruct> ||
           std::is_same_v<T, OpenMPExecutableAllocate>) {
         return MakeName(std::get<Verbatim>(x.t).source, ConstructId<T>::id);
       } else {

Copy link
Contributor

@Stylie777 Stylie777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kparzysz kparzysz merged commit 95069c1 into main Sep 30, 2025
12 checks passed
@kparzysz kparzysz deleted the users/kparzysz/remove-declare-reduction branch September 30, 2025 15:45
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Oct 3, 2025
…NFC (llvm#161390)

DECLARE REDUCTION is now handled by the generic code, and the special
handling no longer applies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:parser flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants