Skip to content

Conversation

klausler
Copy link
Contributor

flang/lib/Evaluate/constant.cpp apparently needs this #include for MSVC builds but somehow not for others.

flang/lib/Evaluate/constant.cpp apparently needs this #include for
MSVC builds but somehow not for others.
@llvmbot llvmbot added flang Flang issues not falling into any other category flang:semantics labels Sep 30, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 30, 2025

@llvm/pr-subscribers-flang-semantics

Author: Peter Klausler (klausler)

Changes

flang/lib/Evaluate/constant.cpp apparently needs this #include for MSVC builds but somehow not for others.


Full diff: https://github.com/llvm/llvm-project/pull/161415.diff

1 Files Affected:

  • (modified) flang/lib/Evaluate/constant.cpp (+1)
diff --git a/flang/lib/Evaluate/constant.cpp b/flang/lib/Evaluate/constant.cpp
index 0fa397b9c356d..8923ab114c737 100644
--- a/flang/lib/Evaluate/constant.cpp
+++ b/flang/lib/Evaluate/constant.cpp
@@ -10,6 +10,7 @@
 #include "flang/Evaluate/expression.h"
 #include "flang/Evaluate/shape.h"
 #include "flang/Evaluate/type.h"
+#include "flang/Semantics/scope.h"
 #include <string>
 
 namespace Fortran::evaluate {

@klausler
Copy link
Contributor Author

I think the original patch passed Windows CI but the Arm Windows build bot is failing due to a lack of definition of semantics::Scope. Please review soon.

@klausler klausler merged commit fad2a4c into llvm:main Sep 30, 2025
12 checks passed
@klausler klausler deleted the fix-msvc branch September 30, 2025 18:46
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Oct 3, 2025
flang/lib/Evaluate/constant.cpp apparently needs this #include for MSVC
builds but somehow not for others.
@llvm-ci
Copy link
Collaborator

llvm-ci commented Oct 8, 2025

LLVM Buildbot has detected a new failure on builder ppc64le-flang-rhel-clang running on ppc64le-flang-rhel-test while building flang at step 6 "test-build-unified-tree-check-flang".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/40883

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-flang) failure: 1200 seconds without output running [b'ninja', b'check-flang'], attempting to kill
...
PASS: Flang :: Lower/derived-types.f90 (3845 of 3855)
PASS: Flang :: Lower/math-lowering/floor.f90 (3846 of 3855)
PASS: Flang :: Lower/math-lowering/nint.f90 (3847 of 3855)
PASS: Flang :: Lower/module_definition.f90 (3848 of 3855)
PASS: Flang :: Lower/dummy-argument-optional.f90 (3849 of 3855)
PASS: Flang :: Lower/program-units-fir-mangling.f90 (3850 of 3855)
PASS: Flang :: Lower/submodule.f90 (3851 of 3855)
PASS: Flang :: Lower/module-generic-with-specific-mangling.f90 (3852 of 3855)
PASS: Flang :: Lower/math-lowering/tan.f90 (3853 of 3855)
PASS: Flang :: Intrinsics/math-codegen.fir (3854 of 3855)
command timed out: 1200 seconds without output running [b'ninja', b'check-flang'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=4176.537598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:semantics flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants