Skip to content

Fix memory leak in Offloading API #161430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

Fix memory leak in Offloading API #161430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa234bf
Fix memory leak in Offloading API
david-salinas Sep 30, 2025
341f10d
fix clang-format errors
david-salinas Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions llvm/lib/Object/OffloadBundle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,15 @@ OffloadBundleFatBin::create(MemoryBufferRef Buf, uint64_t SectionOffset,
if (identify_magic(Buf.getBuffer()) != file_magic::offload_bundle)
return errorCodeToError(object_error::parse_failed);

OffloadBundleFatBin *TheBundle = new OffloadBundleFatBin(Buf, FileName);
std::unique_ptr<OffloadBundleFatBin> TheBundle(
new OffloadBundleFatBin(Buf, FileName));

// Read the Bundle Entries
Error Err = TheBundle->readEntries(Buf.getBuffer(), SectionOffset);
if (Err)
return Err;

return std::unique_ptr<OffloadBundleFatBin>(TheBundle);
return TheBundle;
}

Error OffloadBundleFatBin::extractBundle(const ObjectFile &Source) {
Expand Down