Revert "Fix memory leak in Offloading API" #161465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b80b48d.
Kewen12
approved these changes
Oct 1, 2025
|
@llvm/pr-subscribers-llvm-binary-utilities Author: None (ronlieb) ChangesReverts llvm/llvm-project#161430 Full diff: https://github.com/llvm/llvm-project/pull/161465.diff 1 Files Affected:
diff --git a/llvm/lib/Object/OffloadBundle.cpp b/llvm/lib/Object/OffloadBundle.cpp
index a6a9628acddcc..0dd378e65fd81 100644
--- a/llvm/lib/Object/OffloadBundle.cpp
+++ b/llvm/lib/Object/OffloadBundle.cpp
@@ -120,15 +120,14 @@ OffloadBundleFatBin::create(MemoryBufferRef Buf, uint64_t SectionOffset,
if (identify_magic(Buf.getBuffer()) != file_magic::offload_bundle)
return errorCodeToError(object_error::parse_failed);
- std::unique_ptr<OffloadBundleFatBin> TheBundle(
- new OffloadBundleFatBin(Buf, FileName));
+ OffloadBundleFatBin *TheBundle = new OffloadBundleFatBin(Buf, FileName);
// Read the Bundle Entries
Error Err = TheBundle->readEntries(Buf.getBuffer(), SectionOffset);
if (Err)
return Err;
- return TheBundle;
+ return std::unique_ptr<OffloadBundleFatBin>(TheBundle);
}
Error OffloadBundleFatBin::extractBundle(const ObjectFile &Source) {
|
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/17982 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/11559 Here is the relevant piece of the build log for the reference |
|
Can we reland this? Sanitizer bots are broken again. |
yup, working on a solution. The original fix caused other sanitizer build bots to fail. https://lab.llvm.org/buildbot/#/changes/54686 |
david-salinas
added a commit
to david-salinas/llvm-project
that referenced
this pull request
Oct 1, 2025
This reverts commit d392563.
RiverDave
pushed a commit
that referenced
this pull request
Oct 1, 2025
david-salinas
added a commit
that referenced
this pull request
Oct 2, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
…vm#161573) This reverts commit d392563.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #161430