Skip to content

[MLIR][SCF] Update TestTileUsingCustomLoopOp to check loops param #161490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[MLIR][SCF] Update TestTileUsingCustomLoopOp to check loops param #161490

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd3c232
[MLIR][SCF} Check loops param in existing test
sebvince Oct 1, 2025
6498f4f
Update mlir/test/lib/Interfaces/TilingInterface/TestTilingInterfaceTr…
sebvince Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions mlir/test/lib/Interfaces/TilingInterface/TestTilingInterfaceTransformOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@
#include "mlir/Dialect/Utils/StructuredOpsUtils.h"
#include "mlir/IR/Dominance.h"
#include "mlir/IR/OpImplementation.h"
#include "mlir/Interfaces/LoopLikeInterface.h"
#include "mlir/Interfaces/TilingInterface.h"
#include "mlir/Support/LLVM.h"
#include "llvm/Support/Casting.h"
#include "llvm/Support/Debug.h"

#define DEBUG_TYPE "test-tiling-interface"
Expand Down Expand Up @@ -586,6 +589,15 @@ DiagnosedSilenceableFailure transform::TestTileUsingCustomLoopOp::apply(
ArrayRef<SmallVector<OpFoldResult>> resultOffsets,
ArrayRef<SmallVector<OpFoldResult>> resultSizes,
ValueRange destinationTensors) -> LogicalResult {
if (loops.size() != 1) {
return emitOpError("loop size must be 1");
}
LoopLikeOpInterface loop = loops.front();
scf::ForOp *forOp = dyn_cast<scf::ForOp>(&loop);
if (!forOp)
return emitOpError("unexpected loop type. Expecting scf::ForOp");
rewriter.setInsertionPointToEnd(forOp->getBody());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this changing nothing to the rest of the test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test needs the insertionPoint to be set at the end of getBody of the loop. Previously, it was implicitly set in generateLoopHeaderFn.


SmallVector<Value> yieldValues;
yieldValues.reserve(destinationTensors.size());
for (auto [tiledResult, offsets, sizes, destination] : llvm::zip_equal(
Expand Down