Skip to content

Conversation

charithaintc
Copy link
Contributor

@charithaintc charithaintc commented Oct 1, 2025

Current subgroup distribution test employ the entire xegpu-subgroup-distribute pass which include multiple steps like layout propagation, move func body into warp op, and distribute to work items.

This makes it harder to isolate the testing for xegpu subgroup distribution logic, because certain corner cases may be not supported yet by other steps mentioned above.

This PR introduces a test pass for subgroup distribution logic and isolate the testing for distribution logic. We plan to add more corner case (that were not possible before) covering non-xegpu ops (like vector) in next PRs.

This PR also include,

  1. minor bug fixes in gather/scatter distribution.
  2. bug fix in vector multi reduction lowering where it fails to retain some layouts.

@@ -0,0 +1,216 @@
// RUN: mlir-opt --xevm-attach-target='module=xevm_* chip=pvc' -xegpu-subgroup-distribute \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's reason that the file name having "propogate-layout", the pass seems only having subgroup-distribute.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. layout prop is already done for these tests.

renamed back to subgroup-distribute.mlir

Copy link
Contributor

@Jianhui-Li Jianhui-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charithaintc charithaintc merged commit b86fef8 into llvm:main Oct 3, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants