-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[mlir][xegpu] Create a test pass for subgroup distribution. #161592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mlir][xegpu] Create a test pass for subgroup distribution. #161592
Conversation
@@ -0,0 +1,216 @@ | |||
// RUN: mlir-opt --xevm-attach-target='module=xevm_* chip=pvc' -xegpu-subgroup-distribute \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's reason that the file name having "propogate-layout", the pass seems only having subgroup-distribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. layout prop is already done for these tests.
renamed back to subgroup-distribute.mlir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Current subgroup distribution test employ the entire
xegpu-subgroup-distribute
pass which include multiple steps like layout propagation, move func body into warp op, and distribute to work items.This makes it harder to isolate the testing for xegpu subgroup distribution logic, because certain corner cases may be not supported yet by other steps mentioned above.
This PR introduces a test pass for subgroup distribution logic and isolate the testing for distribution logic. We plan to add more corner case (that were not possible before) covering non-xegpu ops (like vector) in next PRs.
This PR also include,