Skip to content

Conversation

jplehr
Copy link
Contributor

@jplehr jplehr commented Oct 2, 2025

The registration of this callback handler was disabled for some reason. Local testing did not bring up any issues when I enabled it.

Side effect is: Silences current warning about unused function.

The registration of this callback handler was disabled for some reason.
Local testing did not bring up any issues when I enabled it.

Side effect is: Silences current warning about unused function.
@jplehr jplehr requested review from jprotze and mhalk October 2, 2025 11:18
@llvmbot llvmbot added openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime labels Oct 2, 2025
@jplehr
Copy link
Contributor Author

jplehr commented Oct 2, 2025

This PR should fix the warning referenced here: #161532

Copy link
Contributor

@mhalk mhalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's get rid of that warning.
As discussed offline, the dispatch-related handling should be checked and possibly improved. I'm going to implement a non-default ==-operator in the coming days.

@jplehr jplehr merged commit 1c5186c into llvm:main Oct 6, 2025
12 checks passed
@jplehr jplehr deleted the feat/enable-dispatch-callback branch October 6, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants