Skip to content

[NFC][clang-sycl-linker] Avoid ambiguous call to CallingConv #161682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2025
Merged

[NFC][clang-sycl-linker] Avoid ambiguous call to CallingConv #161682

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f54dd6
[NFC][clang-sycl-linker] Avoid ambiguous call to CallingConv
jsji Oct 2, 2025
63ce024
clangformat
jsji Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions clang/tools/clang-sycl-linker/ClangSYCLLinker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,9 +462,10 @@ static Error runAOTCompile(StringRef InputFile, StringRef OutputFile,

// TODO: Consider using LLVM-IR metadata to identify globals of interest
bool isKernel(const Function &F) {
const CallingConv::ID CC = F.getCallingConv();
return CC == CallingConv::SPIR_KERNEL || CC == CallingConv::AMDGPU_KERNEL ||
CC == CallingConv::PTX_Kernel;
const llvm::CallingConv::ID CC = F.getCallingConv();
return CC == llvm::CallingConv::SPIR_KERNEL ||
CC == llvm::CallingConv::AMDGPU_KERNEL ||
CC == llvm::CallingConv::PTX_Kernel;
}

/// Performs the following steps:
Expand Down