Skip to content

Conversation

Jlalond
Copy link
Contributor

@Jlalond Jlalond commented Oct 2, 2025

Fixes some casing mistakes I added in #161581

@Jlalond Jlalond requested a review from JDevlieghere as a code owner October 2, 2025 15:57
@llvmbot llvmbot added the lldb label Oct 2, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 2, 2025

@llvm/pr-subscribers-lldb

Author: Jacob Lalonde (Jlalond)

Changes

Fixes some casing mistakes I added in #161581


Full diff: https://github.com/llvm/llvm-project/pull/161691.diff

2 Files Affected:

  • (modified) lldb/source/API/SBTarget.cpp (+1-1)
  • (modified) lldb/source/Commands/CommandObjectTarget.cpp (+1-1)
diff --git a/lldb/source/API/SBTarget.cpp b/lldb/source/API/SBTarget.cpp
index 90ffe786c696c..0d03250753802 100644
--- a/lldb/source/API/SBTarget.cpp
+++ b/lldb/source/API/SBTarget.cpp
@@ -255,7 +255,7 @@ SBProcess SBTarget::LoadCore(const char *core_file, lldb::SBError &error) {
     ProcessSP process_sp(target_sp->CreateProcess(
         target_sp->GetDebugger().GetListener(), "", &filespec, false));
     if (process_sp) {
-      ElapsedTime loadCoreTime(target_sp->GetStatistics().GetLoadCoreTime());
+      ElapsedTime load_core_time(target_sp->GetStatistics().GetLoadCoreTime());
       error.SetError(process_sp->LoadCore());
       if (error.Success())
         sb_process.SetSP(process_sp);
diff --git a/lldb/source/Commands/CommandObjectTarget.cpp b/lldb/source/Commands/CommandObjectTarget.cpp
index b5fc49d58c1eb..c59d02812f328 100644
--- a/lldb/source/Commands/CommandObjectTarget.cpp
+++ b/lldb/source/Commands/CommandObjectTarget.cpp
@@ -419,7 +419,7 @@ class CommandObjectTargetCreate : public CommandObjectParsed {
           // Seems weird that we Launch a core file, but that is what we
           // do!
           {
-            ElapsedTime loadCoreTime(
+            ElapsedTime load_core_time(
                 target_sp->GetStatistics().GetLoadCoreTime());
             error = process_sp->LoadCore();
           }

@Jlalond Jlalond merged commit 3c8c500 into llvm:main Oct 2, 2025
11 checks passed
mahesh-attarde pushed a commit to mahesh-attarde/llvm-project that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants