Skip to content

Suppress returning larger CXX records in mem on PlayStation #161732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

Suppress returning larger CXX records in mem on PlayStation #161732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions clang/lib/CodeGen/Targets/X86.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1343,9 +1343,10 @@ class X86_64ABIInfo : public ABIInfo {
}

bool returnCXXRecordGreaterThan128InMem() const {
// Clang <= 20.0 did not do this.
// Clang <= 20.0 did not do this, and PlayStation does not do this.
if (getContext().getLangOpts().getClangABICompat() <=
LangOptions::ClangABI::Ver20)
LangOptions::ClangABI::Ver20 ||
getTarget().getTriple().isPS())
return false;

return true;
Expand Down
23 changes: 23 additions & 0 deletions clang/test/CodeGen/X86/avx-cxx-record.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -emit-llvm -O2 -target-cpu x86-64-v3 -o - | FileCheck %s
// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -emit-llvm -O2 -target-cpu x86-64-v3 -fclang-abi-compat=20 -o - | FileCheck --check-prefix CLANG-20 %s
// RUN: %clang_cc1 %s -triple x86_64-sie-ps4 -emit-llvm -O2 -target-cpu x86-64-v3 -o - | FileCheck --check-prefix CLANG-20 %s

using UInt64x2 = unsigned long long __attribute__((__vector_size__(16), may_alias));
using UInt64x4 = unsigned long long __attribute__((__vector_size__(32), may_alias));

template<int id>
struct XMM1 {
Expand All @@ -23,3 +25,24 @@ XMM2 foo() {
((XMM1<1>*)&result)->x = UInt64x2{3, 4};
return result;
}

template<int id>
struct YMM1 {
UInt64x4 x;
};

struct YMM2 : YMM1<0>, YMM1<1> {
};

// CHECK: define{{.*}} @_Z3barv({{.*}} [[ARG:%.*]]){{.*}}
// CLANG-20: define{{.*}} <8 x double> @_Z3barv()
// CHECK: entry:
// CHECK-NEXT: store {{.*}}, ptr [[ARG]]{{.*}}
// CHECK-NEXT: [[TMP1:%.*]] = getelementptr {{.*}}, ptr [[ARG]]{{.*}}
// CHECK-NEXT: store {{.*}}, ptr [[TMP1]]{{.*}}
YMM2 bar() {
YMM2 result;
((YMM1<0>*)&result)->x = UInt64x4{1, 2, 3, 4};
((YMM1<1>*)&result)->x = UInt64x4{5, 6, 7, 8};
return result;
}