Skip to content

Conversation

mizvekov
Copy link
Contributor

@mizvekov mizvekov commented Oct 3, 2025

Fixes the new test introduced in #161765, so that it always uses a triple which supports floating point exceptions.

Otherwise, some post-commit bots fail.

Fixes the new test introduced in #161765, so that it always uses a
triple which supports floating point exceptions.

Otherwise, some post-commit bots fail.
@mizvekov mizvekov self-assigned this Oct 3, 2025
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Oct 3, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 3, 2025

@llvm/pr-subscribers-clang

Author: Matheus Izvekov (mizvekov)

Changes

Fixes the new test introduced in #161765, so that it always uses a triple which supports floating point exceptions.

Otherwise, some post-commit bots fail.


Full diff: https://github.com/llvm/llvm-project/pull/161769.diff

1 Files Affected:

  • (modified) clang/test/SemaTemplate/GH161657.cpp (+1-1)
diff --git a/clang/test/SemaTemplate/GH161657.cpp b/clang/test/SemaTemplate/GH161657.cpp
index 6ec793115db12..5ad4dde855898 100644
--- a/clang/test/SemaTemplate/GH161657.cpp
+++ b/clang/test/SemaTemplate/GH161657.cpp
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -fsyntax-only -std=c++20 -ffp-exception-behavior=strict -verify %s
+// RUN: %clang_cc1 -triple=x86_64 -fsyntax-only -std=c++20 -ffp-exception-behavior=strict -verify %s
 // expected-no-diagnostics
 
 template <class T> struct S {

@mizvekov mizvekov merged commit 065699b into main Oct 3, 2025
11 checks passed
@mizvekov mizvekov deleted the users/mizvekov/GH161765-fix1 branch October 3, 2025 04:36
@mizvekov mizvekov added the skip-precommit-approval PR for CI feedback, not intended for review label Oct 3, 2025
@llvm-ci
Copy link
Collaborator

llvm-ci commented Oct 3, 2025

LLVM Buildbot has detected a new failure on builder lldb-aarch64-windows running on linaro-armv8-windows-msvc-05 while building clang at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/11983

Here is the relevant piece of the build log for the reference
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: commands/help/TestHelp.py (191 of 2322)
PASS: lldb-api :: commands/log/basic/TestLogHandlers.py (192 of 2322)
PASS: lldb-api :: commands/log/invalid-args/TestInvalidArgsLog.py (193 of 2322)
PASS: lldb-api :: commands/log/basic/TestLogging.py (194 of 2322)
PASS: lldb-api :: commands/memory/write/TestMemoryWrite.py (195 of 2322)
PASS: lldb-api :: commands/memory/read/TestMemoryRead.py (196 of 2322)
PASS: lldb-api :: commands/platform/basic/TestPlatformCommand.py (197 of 2322)
PASS: lldb-api :: commands/platform/basic/TestPlatformPython.py (198 of 2322)
PASS: lldb-api :: commands/platform/file/close/TestPlatformFileClose.py (199 of 2322)
PASS: lldb-api :: commands/platform/file/read/TestPlatformFileRead.py (200 of 2322)
FAIL: lldb-api :: commands/platform/launchgdbserver/TestPlatformLaunchGDBServer.py (201 of 2322)
******************** TEST 'lldb-api :: commands/platform/launchgdbserver/TestPlatformLaunchGDBServer.py' FAILED ********************
Script:
--
C:/Users/tcwg/scoop/apps/python/current/python.exe C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/llvm-project/lldb\test\API\dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --env LLVM_INCLUDE_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/include --env LLVM_TOOLS_DIR=C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --arch aarch64 --build-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex --lldb-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-lldb\lldb-api --clang-module-cache-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/lldb-test-build.noindex/module-cache-clang\lldb-api --executable C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/lldb.exe --compiler C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/clang.exe --dsymutil C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin/dsymutil.exe --make C:/Users/tcwg/scoop/shims/make.exe --llvm-tools-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./bin --lldb-obj-root C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/tools/lldb --lldb-libs-dir C:/Users/tcwg/llvm-worker/lldb-aarch64-windows/build/./lib --cmake-build-type Release --skip-category=watchpoint C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\commands\platform\launchgdbserver -p TestPlatformLaunchGDBServer.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 22.0.0git (https://github.com/llvm/llvm-project.git revision 065699b34316f5dca74ed7e88c3958d488869bec)
  clang revision 065699b34316f5dca74ed7e88c3958d488869bec
  llvm revision 065699b34316f5dca74ed7e88c3958d488869bec
Skipping the following test categories: ['watchpoint', 'libc++', 'libstdcxx', 'dwo', 'dsym', 'gmodules', 'debugserver', 'objc', 'fork', 'pexpect']


--
Command Output (stderr):
--
UNSUPPORTED: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_launch_error (TestPlatformLaunchGDBServer.TestPlatformProcessLaunchGDBServer.test_launch_error) (requires one of linux) 

lldb-server exiting...

FAIL: LLDB (C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\build\bin\clang.exe-aarch64) :: test_launch_with_unusual_process_name (TestPlatformLaunchGDBServer.TestPlatformProcessLaunchGDBServer.test_launch_with_unusual_process_name)

======================================================================

FAIL: test_launch_with_unusual_process_name (TestPlatformLaunchGDBServer.TestPlatformProcessLaunchGDBServer.test_launch_with_unusual_process_name)

   Test that lldb-server can launch a debug session when running under an

----------------------------------------------------------------------

Traceback (most recent call last):

  File "C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\API\commands\platform\launchgdbserver\TestPlatformLaunchGDBServer.py", line 83, in test_launch_with_unusual_process_name

    self.expect("run", substrs=["exited with status = 0"])


MixedMatched pushed a commit to MixedMatched/llvm-project that referenced this pull request Oct 3, 2025
Fixes the new test introduced in llvm#161765, so that it always uses a
triple which supports floating point exceptions.

Otherwise, some post-commit bots fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category skip-precommit-approval PR for CI feedback, not intended for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants