Skip to content

[mlir][NFC] Remove redundant insertion point changes #161837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
Merged

[mlir][NFC] Remove redundant insertion point changes #161837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01be0d1
[mlir][NFC] Remove redundant insertion point changes
zero9178 Oct 3, 2025
ee6498d
clang-format
zero9178 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions mlir/lib/Conversion/SPIRVToLLVM/ConvertLaunchFuncToLLVMCalls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,9 +267,8 @@ class GPULaunchLowering : public ConvertOpToLLVMPattern<gpu::LaunchFuncOp> {
copyInfo.push_back(info);
}
// Create a call to the kernel and copy the data back.
Operation *callOp = rewriter.replaceOpWithNewOp<LLVM::CallOp>(
op, kernelFunc, ArrayRef<Value>());
rewriter.setInsertionPointAfter(callOp);
rewriter.replaceOpWithNewOp<LLVM::CallOp>(op, kernelFunc,
ArrayRef<Value>());
for (CopyInfo info : copyInfo)
copy(loc, info.src, info.dst, info.size, rewriter);
return success();
Expand Down
1 change: 0 additions & 1 deletion mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamed.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,6 @@ class MaxPool2dConverter : public OpConversionPattern<tosa::MaxPool2dOp> {
ValueRange{paddedInput, fakeWindowDims}, filledEmptyTensor, strideAttr,
dilationAttr);

rewriter.setInsertionPointAfter(op);
NanPropagationMode nanMode = op.getNanMode();
rewriter.replaceOp(op, resultOp);

Expand Down