Skip to content

[clang][x86][bytecode] Replace interp__builtin_rotate with static bool interp__builtin_elementwise_int_binop callback #160289 #161924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2025
Merged

[clang][x86][bytecode] Replace interp__builtin_rotate with static bool interp__builtin_elementwise_int_binop callback #160289 #161924

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a347f6
llvm#160289 added new rotate right and left helper functions and chan…
rdez13 Oct 3, 2025
ffb2a3f
llvm#160289 removed helper functions and used non capturing lambdas i…
rdez13 Oct 4, 2025
1132144
llvm#160289 computed amount as B.urem(A.getBitWidth()) to match previ…
rdez13 Oct 4, 2025
1e18ebe
llvm#160289 replaced A and B with Value and Amount, removed the expli…
rdez13 Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 8 additions & 21 deletions clang/lib/AST/ByteCode/InterpBuiltin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,25 +736,6 @@ static bool interp__builtin_expect(InterpState &S, CodePtr OpPC,
return true;
}

/// rotateleft(value, amount)
static bool interp__builtin_rotate(InterpState &S, CodePtr OpPC,
const InterpFrame *Frame,
const CallExpr *Call, bool Right) {
APSInt Amount = popToAPSInt(S, Call->getArg(1));
APSInt Value = popToAPSInt(S, Call->getArg(0));

APSInt Result;
if (Right)
Result = APSInt(Value.rotr(Amount.urem(Value.getBitWidth())),
/*IsUnsigned=*/true);
else // Left.
Result = APSInt(Value.rotl(Amount.urem(Value.getBitWidth())),
/*IsUnsigned=*/true);

pushInteger(S, Result, Call->getType());
return true;
}

static bool interp__builtin_ffs(InterpState &S, CodePtr OpPC,
const InterpFrame *Frame,
const CallExpr *Call) {
Expand Down Expand Up @@ -3162,7 +3143,10 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call,
case Builtin::BI_rotl:
case Builtin::BI_lrotl:
case Builtin::BI_rotl64:
return interp__builtin_rotate(S, OpPC, Frame, Call, /*Right=*/false);
return interp__builtin_elementwise_int_binop(
S, OpPC, Call, [](const APSInt &Value, const APSInt &Amount) -> APInt {
return Value.rotl(Amount);
});

case Builtin::BI__builtin_rotateright8:
case Builtin::BI__builtin_rotateright16:
Expand All @@ -3173,7 +3157,10 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call,
case Builtin::BI_rotr:
case Builtin::BI_lrotr:
case Builtin::BI_rotr64:
return interp__builtin_rotate(S, OpPC, Frame, Call, /*Right=*/true);
return interp__builtin_elementwise_int_binop(
S, OpPC, Call, [](const APSInt &Value, const APSInt &Amount) -> APInt {
return Value.rotr(Amount);
});

case Builtin::BI__builtin_ffs:
case Builtin::BI__builtin_ffsl:
Expand Down