Skip to content

[WebAssembly] Check intrinsic argument count before Any/All combine #162163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2025
Merged

[WebAssembly] Check intrinsic argument count before Any/All combine #162163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3416a8b
[WebAssembly] Check intrinsic argument count before Any/All combine
dschuff Oct 6, 2025
0071179
add test expectation
dschuff Oct 7, 2025
43cd92b
Merge branch 'main' into intrinsic
dschuff Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3209,7 +3209,8 @@ static SDValue performAnyAllCombine(SDNode *N, SelectionDAG &DAG) {
using namespace llvm::SDPatternMatch;

SDValue LHS;
if (!sd_match(N->getOperand(1),
if (N->getNumOperands() < 2 ||
!sd_match(N->getOperand(1),
m_c_SetCC(m_Value(LHS), m_Zero(), m_CondCode())))
return SDValue();
EVT LT = LHS.getValueType();
Expand Down
13 changes: 13 additions & 0 deletions llvm/test/CodeGen/WebAssembly/simd-setcc-reductions.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,4 +132,17 @@ define i32 @all_true_2_4_i32(<4 x i32> %v) {
ret i32 %conv3
}

; Regression test for the intrinsic pattern matcher with nullary intrinsics
define i64 @other_intrinsic() #0 {
; CHECK-LABEL: other_intrinsic:
; CHECK: .functype other_intrinsic () -> (i64)
; CHECK-NEXT: # %bb.0: # %entry
; CHECK-NEXT: global.get $push0=, __tls_align
; CHECK-NEXT: return $pop0
entry:
%0 = call i64 @llvm.wasm.tls.align.i64()
ret i64 %0
}

attributes #0 = { "target-features"="+atomics" }