[NFC][clang] Precommit test with confusing behavior of suppression list

[vitalybuka]

I want to change behavior, but none of existing tests sees the difference.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Vitaly Buka (vitalybuka)

Changes

I want to change behavior, but none of existing tests sees the difference.

---

Full diff: https://github.com/llvm/llvm-project/pull/162192.diff

1 Files Affected:

• (modified) clang/unittests/Basic/DiagnosticTest.cpp (+19)

diff --git a/clang/unittests/Basic/DiagnosticTest.cpp b/clang/unittests/Basic/DiagnosticTest.cpp
index 4b3af00c3b0ce..bf0d68ba3b41e 100644
--- a/clang/unittests/Basic/DiagnosticTest.cpp
+++ b/clang/unittests/Basic/DiagnosticTest.cpp
@@ -314,6 +314,25 @@ TEST_F(SuppressionMappingTest, LongestMatchWins) {
                                            locForFile("clang/lib/Sema/foo.h")));
 }
 
+TEST_F(SuppressionMappingTest, LongShortMatch) {
+  llvm::StringLiteral SuppressionMappingFile = R"(
+  [unused]
+  src:*test/*
+  src:*lld/*=emit)";
+  Diags.getDiagnosticOptions().DiagnosticSuppressionMappingsFile = "foo.txt";
+  FS->addFile("foo.txt", /*ModificationTime=*/{},
+              llvm::MemoryBuffer::getMemBuffer(SuppressionMappingFile));
+  clang::ProcessWarningOptions(Diags, Diags.getDiagnosticOptions(), *FS);
+  EXPECT_THAT(diags(), IsEmpty());
+
+  EXPECT_TRUE(Diags.isSuppressedViaMapping(diag::warn_unused_function,
+                                           locForFile("test/my_test1.cpp")));
+
+  // FIXME: This is confusing.
+  EXPECT_TRUE(Diags.isSuppressedViaMapping(diag::warn_unused_function,
+                                           locForFile("lld/test/my_test2.cpp")));
+}
+
 TEST_F(SuppressionMappingTest, IsIgnored) {
   llvm::StringLiteral SuppressionMappingFile = R"(
   [unused]

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.