Skip to content

[DFAJumpThreading] Update domtree lazily #162240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2025
Merged

[DFAJumpThreading] Update domtree lazily #162240

merged 2 commits into from
Oct 7, 2025

Conversation

XChy
Copy link
Member

@XChy XChy commented Oct 7, 2025

No description provided.

@XChy XChy requested review from nikic and UsmanNadeem October 7, 2025 08:11
nikic
nikic approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It might make sense to have everything use a single lazy DTU and then use DTU->getDomTree() in updateSSA(), which seems like the only place that actually needs an up to date dominator tree.

@XChy XChy force-pushed the dfa-jump-thread-lazy-DTU branch from c7d26ac to b21f1e3 Compare October 7, 2025 10:02
@XChy XChy enabled auto-merge (squash) October 7, 2025 10:02
@XChy XChy merged commit ed113e7 into llvm:main Oct 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

@UsmanNadeem UsmanNadeem Awaiting requested review from UsmanNadeem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XChy @nikic