Skip to content

[DFAJumpThreading] Set MadeChanges only if threading happened #162241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

[DFAJumpThreading] Set MadeChanges only if threading happened #162241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cb12b6
[DFAJumpThreading] Set MadeChanges only if threading happened
XChy Oct 7, 2025
bbdd8a9
resolve comment
XChy Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions llvm/lib/Transforms/Scalar/DFAJumpThreading.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -820,11 +820,13 @@ struct TransformDFA {
: SwitchPaths(SwitchPaths), DT(DT), AC(AC), TTI(TTI), ORE(ORE),
EphValues(EphValues) {}

void run() {
bool run() {
if (isLegalAndProfitableToTransform()) {
createAllExitPaths();
NumTransforms++;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You could just return true here and return false below. No need for the variable.

return true;
}
return false;
}

private:
Expand Down Expand Up @@ -1426,9 +1428,8 @@ bool DFAJumpThreading::run(Function &F) {

for (AllSwitchPaths SwitchPaths : ThreadableLoops) {
TransformDFA Transform(&SwitchPaths, DT, AC, TTI, ORE, EphValues);
Transform.run();
MadeChanges = true;
LoopInfoBroken = true;
if (Transform.run())
MadeChanges = LoopInfoBroken = true;
}

#ifdef EXPENSIVE_CHECKS
Expand Down
Loading