Skip to content

Conversation

chandmudda
Copy link

Earlier we were using partial threshold to calculate unroll count for loop but for small loops it is giving more unroll count which is degrading the performance.Using Scaled Threshold improves the performance.

Earlier we were using partial threshold to calculate unroll count
for loop but for small loops it is giving more unroll count which
is degrading the performance.Using Scaled Threshold improves
the performance.
Copy link

github-actions bot commented Oct 7, 2025

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@chandmudda
Copy link
Author

@androm3da , Please suggest some reviewers who can take a look at this patch.

@androm3da
Copy link
Member

@androm3da , Please suggest some reviewers who can take a look at this patch.

Thanks for the PR!

@fhahn or @HankChang736 might be good reviewers? They've touched the file ~recently.

@androm3da
Copy link
Member

but for small loops it is giving more unroll count which is degrading the performance.Using Scaled Threshold improves the performance.

OBTW I've never made any real codegen changes but for the community's sake you should probably disclose the benchmark you are using here, and perhaps any other benchmarks that you think have at least neutral impact (to avoid performance regressions caused by this change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants