-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[NFC][SpecialCaseList] Hide more details in private section #162302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vitalybuka
merged 9 commits into
main
from
users/vitalybuka/spr/nfcsupport-make-private-internals-details-of-matcher
Oct 8, 2025
Merged
[NFC][SpecialCaseList] Hide more details in private section #162302
vitalybuka
merged 9 commits into
main
from
users/vitalybuka/spr/nfcsupport-make-private-internals-details-of-matcher
Oct 8, 2025
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
@llvm/pr-subscribers-clang @llvm/pr-subscribers-llvm-support Author: Vitaly Buka (vitalybuka) ChangesFull diff: https://github.com/llvm/llvm-project/pull/162302.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Support/SpecialCaseList.h b/llvm/include/llvm/Support/SpecialCaseList.h
index c2c9271b0a37a..e824cd44f6297 100644
--- a/llvm/include/llvm/Support/SpecialCaseList.h
+++ b/llvm/include/llvm/Support/SpecialCaseList.h
@@ -121,12 +121,15 @@ class SpecialCaseList {
/// Represents a set of globs and their line numbers
class Matcher {
public:
- LLVM_ABI Error insert(StringRef Pattern, unsigned LineNumber,
- bool UseRegex);
// Returns the line number in the source file that this query matches to.
// Returns zero if no match is found.
LLVM_ABI unsigned match(StringRef Query) const;
+ private:
+ friend class SpecialCaseList;
+ LLVM_ABI Error insert(StringRef Pattern, unsigned LineNumber,
+ bool UseRegex);
+
struct Glob {
std::string Name;
unsigned LineNo;
|
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
thurstond
approved these changes
Oct 8, 2025
fmayer
approved these changes
Oct 8, 2025
Created using spr 1.3.6 [skip ci]
svkeerthy
pushed a commit
that referenced
this pull request
Oct 9, 2025
clingfei
pushed a commit
to clingfei/llvm-project
that referenced
this pull request
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
clang:frontend
Language frontend issues, e.g. anything involving "Sema"
clang
Clang issues not falling into any other category
llvm:support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.