Skip to content

Conversation

vitalybuka
Copy link
Collaborator

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Oct 7, 2025

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-llvm-support

Author: Vitaly Buka (vitalybuka)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/162302.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Support/SpecialCaseList.h (+5-2)
diff --git a/llvm/include/llvm/Support/SpecialCaseList.h b/llvm/include/llvm/Support/SpecialCaseList.h
index c2c9271b0a37a..e824cd44f6297 100644
--- a/llvm/include/llvm/Support/SpecialCaseList.h
+++ b/llvm/include/llvm/Support/SpecialCaseList.h
@@ -121,12 +121,15 @@ class SpecialCaseList {
   /// Represents a set of globs and their line numbers
   class Matcher {
   public:
-    LLVM_ABI Error insert(StringRef Pattern, unsigned LineNumber,
-                          bool UseRegex);
     // Returns the line number in the source file that this query matches to.
     // Returns zero if no match is found.
     LLVM_ABI unsigned match(StringRef Query) const;
 
+  private:
+    friend class SpecialCaseList;
+    LLVM_ABI Error insert(StringRef Pattern, unsigned LineNumber,
+                          bool UseRegex);
+
     struct Glob {
       std::string Name;
       unsigned LineNo;

Created using spr 1.3.6

[skip ci]
Created using spr 1.3.6
Created using spr 1.3.6

[skip ci]
Created using spr 1.3.6
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Oct 8, 2025
@vitalybuka vitalybuka requested review from fmayer and thurstond October 8, 2025 03:12
@vitalybuka vitalybuka changed the title [NFC][Support] Make private internals details of Matcher [NFC][SpecialCaseList] Hide more details in private section Oct 8, 2025
Created using spr 1.3.6

[skip ci]
Created using spr 1.3.6
@vitalybuka vitalybuka changed the base branch from users/vitalybuka/spr/main.nfcsupport-make-private-internals-details-of-matcher to main October 8, 2025 19:43
Created using spr 1.3.6
@vitalybuka vitalybuka enabled auto-merge (squash) October 8, 2025 19:49
@vitalybuka vitalybuka merged commit 857961d into main Oct 8, 2025
7 of 8 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/nfcsupport-make-private-internals-details-of-matcher branch October 8, 2025 20:22
clingfei pushed a commit to clingfei/llvm-project that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category llvm:support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants