[BOLT][AArch64] Fix perf2bolt-spe test #162312
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lit recently started failing on some machines when using a subshell. The test used a subshell to handle kernels where SPE's brstack option is unavailable (<6.14), but it appears to work without it now. Tested with perf 6.8 and 6.17.
paschalis-mpeis
requested review from
aaupov,
ayermolo,
maksfb,
rafaelauler,
yota9 and
yozhu
as code owners
|
@llvm/pr-subscribers-bolt Author: Paschalis Mpeis (paschalis-mpeis) ChangesLit recently started failing on some machines when using a subshell. The test used a subshell to handle kernels where SPE's brstack option is unavailable (<6.14), but it appears to work without it now. Tested with perf 6.8 and 6.17. Full diff: https://github.com/llvm/llvm-project/pull/162312.diff 1 Files Affected:
diff --git a/bolt/test/perf2bolt/AArch64/perf2bolt-spe.test b/bolt/test/perf2bolt/AArch64/perf2bolt-spe.test
index 91f5c857fbab0..1f44f7510a9fb 100644
--- a/bolt/test/perf2bolt/AArch64/perf2bolt-spe.test
+++ b/bolt/test/perf2bolt/AArch64/perf2bolt-spe.test
@@ -6,7 +6,6 @@ RUN: %clang %cflags %p/../../Inputs/asm_foo.s %p/../../Inputs/asm_main.c -o %t.e
RUN: perf record -e cycles -q -o %t.perf.data -- %t.exe 2> /dev/null
-RUN: (perf2bolt -p %t.perf.data -o %t.perf.boltdata --spe %t.exe 2> /dev/null; exit 0) | FileCheck %s --check-prefix=CHECK-SPE-LBR
+RUN: perf2bolt -p %t.perf.data -o %t.perf.boltdata --spe %t.exe | FileCheck %s --check-prefix=CHECK-SPE-LBR
CHECK-SPE-LBR: PERF2BOLT: parse SPE branch events in LBR-format
-
|
|
(also want to add @kaadam to the reviewers on this patch, but can't just yet). |
|
Paschalis, thanks for fixing this test, it works. Informal LGTM from me. |
|
Great, thanks a lot @kaadam. Could someone stamp this please? |
maksfb
approved these changes
Oct 8, 2025
svkeerthy
pushed a commit
that referenced
this pull request
Oct 9, 2025
Lit recently started failing on some machines when using a subshell. The test used a subshell to handle kernels where SPE's brstack option is unavailable (<6.14), but it appears to work without it now. Tested with perf 6.8 and 6.17.
clingfei
pushed a commit
to clingfei/llvm-project
that referenced
this pull request
Oct 10, 2025
Lit recently started failing on some machines when using a subshell. The test used a subshell to handle kernels where SPE's brstack option is unavailable (<6.14), but it appears to work without it now. Tested with perf 6.8 and 6.17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lit recently started failing on some machines when using a subshell. The test used a subshell to handle kernels where SPE's brstack option is unavailable (<6.14), but it appears to work without it now.
Tested with perf 6.8 and 6.17.