Skip to content

[Offload] Let binary utility take empty arguments #162317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

[Offload] Let binary utility take empty arguments #162317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/test/tools/llvm-offload-binary/llvm-offload-binary.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@
; CHECK-NEXT: arch abc
; CHECK-NEXT: triple x-y-z
; CHECK-NEXT: producer none

; RUN: llvm-offload-binary -o %t3 --image=file=%s
; RUN: llvm-offload-binary %t3 --image=file=%t4
; RUN: diff %s %t4
7 changes: 3 additions & 4 deletions llvm/tools/llvm-offload-binary/llvm-offload-binary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,9 @@ static Error bundleImages() {
StringSaver Saver(Alloc);
DenseMap<StringRef, StringRef> Args = getImageArguments(Image, Saver);

if (!Args.count("triple") || !Args.count("file"))
return createStringError(
inconvertibleErrorCode(),
"'file' and 'triple' are required image arguments");
if (!Args.count("file"))
return createStringError(inconvertibleErrorCode(),
"'file' is a required image arguments");

// Permit using multiple instances of `file` in a single string.
for (auto &File : llvm::split(Args["file"], ",")) {
Expand Down