Skip to content

[MIR2Vec] Fixing non x86 unittest failures #162381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
Merged

[MIR2Vec] Fixing non x86 unittest failures #162381

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
052117b
Fixing non x86 test failures
svkeerthy Oct 7, 2025
588103e
Adding reasons
svkeerthy Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 23 additions & 15 deletions llvm/unittests/CodeGen/MIR2VecTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,27 +54,32 @@ class MIR2VecVocabTestFixture : public ::testing::Test {
std::unique_ptr<TargetMachine> TM;
const TargetInstrInfo *TII;

static void SetUpTestCase() {
InitializeAllTargets();
InitializeAllTargetMCs();
}

void SetUp() override {
LLVMInitializeX86TargetInfo();
LLVMInitializeX86Target();
LLVMInitializeX86TargetMC();
Triple TargetTriple("x86_64-unknown-linux-gnu");
std::string Error;
const Target *T = TargetRegistry::lookupTarget("", TargetTriple, Error);
if (!T) {
GTEST_SKIP() << "x86_64-unknown-linux-gnu target triple not available; "
"Skipping test";
return;
}

Ctx = std::make_unique<LLVMContext>();
M = std::make_unique<Module>("test", *Ctx);

// Set up X86 target
Triple TargetTriple("x86_64-unknown-linux-gnu");
M->setTargetTriple(TargetTriple);

std::string Error;
const Target *TheTarget =
TargetRegistry::lookupTarget(M->getTargetTriple(), Error);
ASSERT_TRUE(TheTarget) << "Failed to lookup target: " << Error;

TargetOptions Options;
TM = std::unique_ptr<TargetMachine>(TheTarget->createTargetMachine(
M->getTargetTriple(), "", "", Options, Reloc::Model::Static));
ASSERT_TRUE(TM);
TM = std::unique_ptr<TargetMachine>(
T->createTargetMachine(TargetTriple, "", "", Options, std::nullopt));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if T is valid, can TM not be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just being conservative here to skip such tests, as I was not completely sure if TM cannot not be nullptr if T is valid.

if (!TM) {
GTEST_SKIP() << "Failed to create X86 target machine; Skipping test";
return;
}

// Create a dummy function to get subtarget info
FunctionType *FT = FunctionType::get(Type::getVoidTy(*Ctx), false);
Expand All @@ -83,7 +88,10 @@ class MIR2VecVocabTestFixture : public ::testing::Test {

// Get the target instruction info
TII = TM->getSubtargetImpl(*F)->getInstrInfo();
ASSERT_TRUE(TII);
if (!TII) {
GTEST_SKIP() << "Failed to get target instruction info; Skipping test";
return;
}
}
};

Expand Down
Loading