Skip to content

[lldb] Enforce that only the LLDB API unit tests can link liblldb #162384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
+9 −1
Merged

[lldb] Enforce that only the LLDB API unit tests can link liblldb #162384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lldb/unittests/API/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ add_lldb_unittest(APITests
SBLineEntryTest.cpp
SBMutexTest.cpp

SBAPITEST

LINK_LIBS
liblldb
)
Expand Down
6 changes: 5 additions & 1 deletion lldb/unittests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ endif()

function(add_lldb_unittest test_name)
cmake_parse_arguments(ARG
""
"SBAPITEST"
""
"LINK_LIBS;LINK_COMPONENTS"
${ARGN})
Expand All @@ -21,6 +21,10 @@ function(add_lldb_unittest test_name)
message(FATAL_ERROR "Unit test name must end with 'Tests' for lit to find it.")
endif()

if ("liblldb" IN_LIST ARG_LINK_LIBS AND NOT ARG_SBAPITEST)
message(FATAL_ERROR "The ${test_name} are not allowed to link liblldb.")
endif()

list(APPEND LLVM_LINK_COMPONENTS ${ARG_LINK_COMPONENTS})

add_unittest(LLDBUnitTests
Expand Down
2 changes: 2 additions & 0 deletions lldb/unittests/DAP/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ add_lldb_unittest(DAPTests
TestBase.cpp
VariablesTest.cpp

SBAPITEST

LINK_COMPONENTS
Support
LINK_LIBS
Expand Down
Loading