Skip to content

Conversation

vitalybuka
Copy link
Collaborator

@vitalybuka vitalybuka commented Oct 7, 2025

This way we can roll out new breaking features as opt-int.
E.g. "#!special-case-list-v3" will enabled something new.

Nothing to enabled yet, but with pinpointed default it's an option.

Follow up #162350.

Created using spr 1.3.6
@llvmbot
Copy link
Member

llvmbot commented Oct 7, 2025

@llvm/pr-subscribers-llvm-support

Author: Vitaly Buka (vitalybuka)

Changes

This way we can roll out new breaking features as opt-int.
E.g. "#!special-case-list-v3" will enabled something new.

Nothing to enabled yet, but with pinpointed default it's an option.


Full diff: https://github.com/llvm/llvm-project/pull/162398.diff

1 Files Affected:

  • (modified) llvm/lib/Support/SpecialCaseList.cpp (+1-1)
diff --git a/llvm/lib/Support/SpecialCaseList.cpp b/llvm/lib/Support/SpecialCaseList.cpp
index c0bfeb4020872..f18cc391c6998 100644
--- a/llvm/lib/Support/SpecialCaseList.cpp
+++ b/llvm/lib/Support/SpecialCaseList.cpp
@@ -150,7 +150,7 @@ SpecialCaseList::addSection(StringRef SectionStr, unsigned FileNo,
 
 bool SpecialCaseList::parse(unsigned FileIdx, const MemoryBuffer *MB,
                             std::string &Error) {
-  unsigned long long Version = std::numeric_limits<unsigned long long>::max();
+  unsigned long long Version = 2;
 
   StringRef Header = MB->getBuffer();
   if (Header.consume_front("#!special-case-list-v"))

@vitalybuka vitalybuka requested a review from qinkunbao October 7, 2025 23:40
@vitalybuka vitalybuka enabled auto-merge (squash) October 7, 2025 23:43
@vitalybuka vitalybuka merged commit e5d15c1 into main Oct 8, 2025
11 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/nfcspecialcaselist-make-default-version-2-instead-of-max branch October 8, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants