[SPARC] Fix-forward #154950 by returning true if SP::V8BAR is handled #162424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dled Buildbot report: https://lab.llvm.org/buildbot/#/builders/24/builds/13433 Use-after-poison happens because after SP::V8BAR is handled, it erases MI, which should thereafter not be inspected by ExpandPostRA::run.
|
@llvm/pr-subscribers-backend-sparc Author: Thurston Dang (thurstond) ChangesBuildbot report: https://lab.llvm.org/buildbot/#/builders/24/builds/13433 Use-after-poison happens because after SP::V8BAR is handled, it erases MI, which should thereafter not be inspected by ExpandPostRA::run. Full diff: https://github.com/llvm/llvm-project/pull/162424.diff 1 Files Affected:
diff --git a/llvm/lib/Target/Sparc/SparcInstrInfo.cpp b/llvm/lib/Target/Sparc/SparcInstrInfo.cpp
index c0cd0176efa30..f66eb9dbee2dc 100644
--- a/llvm/lib/Target/Sparc/SparcInstrInfo.cpp
+++ b/llvm/lib/Target/Sparc/SparcInstrInfo.cpp
@@ -668,6 +668,7 @@ bool SparcInstrInfo::expandPostRAPseudo(MachineInstr &MI) const {
.addImm(-1);
MIBundleBuilder(MBB, InstSTBAR, InstLDSTUB);
MBB.erase(MI);
+ return true;
}
}
return false;
|
|
Compilation is running slowly, I will check if the test(s) needs updating |
arsenm
approved these changes
Oct 8, 2025
thurstond
changed the title
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/21805 Here is the relevant piece of the build log for the reference |
svkeerthy
pushed a commit
that referenced
this pull request
Oct 9, 2025
…#162424) Use-after-poison happens because after SP::V8BAR is handled, it erases MI, which therefore should not be inspected by `ExpandPostRA::run()`. This fixes a buildbot-reported issue from #154950 (https://lab.llvm.org/buildbot/#/builders/24/builds/13433).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use-after-poison happens because after SP::V8BAR is handled, it erases MI, which should therefore not be inspected by
ExpandPostRA::run().This fixes a buildbot reported issue from #154950 (https://lab.llvm.org/buildbot/#/builders/24/builds/13433).