Skip to content

[ADT] Modernize Bitset (NFC) #162430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

[ADT] Modernize Bitset (NFC) #162430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0ba222
[ADT] Modernize Bitset (NFC)
kazutakahirata Oct 7, 2025
ac429a0
Address a comment.
kazutakahirata Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions llvm/include/llvm/ADT/Bitset.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@ namespace llvm {
/// initialization.
template <unsigned NumBits>
class Bitset {
typedef uintptr_t BitWord;
using BitWord = uintptr_t;

enum { BITWORD_SIZE = (unsigned)sizeof(BitWord) * CHAR_BIT };
static constexpr unsigned BitwordBits = sizeof(BitWord) * CHAR_BIT;

static_assert(BITWORD_SIZE == 64 || BITWORD_SIZE == 32,
static_assert(BitwordBits == 64 || BitwordBits == 32,
"Unsupported word size");

static constexpr unsigned NumWords =
(NumBits + BITWORD_SIZE - 1) / BITWORD_SIZE;
(NumBits + BitwordBits - 1) / BitwordBits;

protected:
using StorageType = std::array<BitWord, NumWords>;
Expand All @@ -60,23 +60,23 @@ class Bitset {
}

constexpr Bitset &set(unsigned I) {
Bits[I / BITWORD_SIZE] |= BitWord(1) << (I % BITWORD_SIZE);
Bits[I / BitwordBits] |= BitWord(1) << (I % BitwordBits);
return *this;
}

constexpr Bitset &reset(unsigned I) {
Bits[I / BITWORD_SIZE] &= ~(BitWord(1) << (I % BITWORD_SIZE));
Bits[I / BitwordBits] &= ~(BitWord(1) << (I % BitwordBits));
return *this;
}

constexpr Bitset &flip(unsigned I) {
Bits[I / BITWORD_SIZE] ^= BitWord(1) << (I % BITWORD_SIZE);
Bits[I / BitwordBits] ^= BitWord(1) << (I % BitwordBits);
return *this;
}

constexpr bool operator[](unsigned I) const {
BitWord Mask = BitWord(1) << (I % BITWORD_SIZE);
return (Bits[I / BITWORD_SIZE] & Mask) != 0;
BitWord Mask = BitWord(1) << (I % BitwordBits);
return (Bits[I / BitwordBits] & Mask) != 0;
}

constexpr bool test(unsigned I) const { return (*this)[I]; }
Expand Down