-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[OpenMP][docs] Update OpenMP 6.0 OMP_AVAILABLE_DEVICES status #162440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The trait support being implemented for OMP_DEFAULT_DEVICES can also be used for OMP_ABVAILABLE_DEVICES, which makes it reasonable to wait to avoid duplicate effort.
@llvm/pr-subscribers-clang Author: Robert Imschweiler (ro-i) ChangesThe trait support being implemented for OMP_DEFAULT_DEVICES can also be used for OMP_ABVAILABLE_DEVICES, which makes it reasonable to wait to avoid duplicate effort. Full diff: https://github.com/llvm/llvm-project/pull/162440.diff 1 Files Affected:
diff --git a/clang/docs/OpenMPSupport.rst b/clang/docs/OpenMPSupport.rst
index 90c0186e47ea7..cdb3b331a25e7 100644
--- a/clang/docs/OpenMPSupport.rst
+++ b/clang/docs/OpenMPSupport.rst
@@ -548,7 +548,7 @@ implementation.
+-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+
| Increment between places for OMP_PLACES | :none:`unclaimed` | :none:`unclaimed` | |
+-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+
-| OMP_AVAILABLE_DEVICES envirable | :none:`unclaimed` | :none:`unclaimed` | |
+| OMP_AVAILABLE_DEVICES envirable | :none:`unclaimed` | :none:`unclaimed` | (should wait for "Traits for default device envirable" being done) |
+-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+
| Traits for default device envirable | :part:`in progress` | :none:`unclaimed` | ro-i |
+-------------------------------------------------------------+---------------------------+---------------------------+--------------------------------------------------------------------------+
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/23737 Here is the relevant piece of the build log for the reference
|
(failure is in a clangd unit test -> unrelated to this PR) |
The trait support being implemented for OMP_DEFAULT_DEVICES can also be used for OMP_AVAILABLE_DEVICES, which makes it reasonable to wait to avoid duplicate effort.
…62440) The trait support being implemented for OMP_DEFAULT_DEVICES can also be used for OMP_AVAILABLE_DEVICES, which makes it reasonable to wait to avoid duplicate effort.
The trait support being implemented for OMP_DEFAULT_DEVICES can also be used for OMP_AVAILABLE_DEVICES, which makes it reasonable to wait to avoid duplicate effort.