Skip to content

[orc-rt] Enable SPS transparent conversion for reference arguments. #162563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
+13 −1
Merged

[orc-rt] Enable SPS transparent conversion for reference arguments. #162563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion orc-rt/include/orc-rt/SPSWrapperFunction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ template <typename... SPSArgTs> struct WFSPSHelper {
public:
template <typename... ArgTs>
std::optional<WrapperFunctionBuffer> serialize(ArgTs &&...Args) {
return serializeImpl(Serializable<ArgTs>::to(std::forward<ArgTs>(Args))...);
return serializeImpl(
Serializable<std::decay_t<ArgTs>>::to(std::forward<ArgTs>(Args))...);
}

template <typename ArgTuple>
Expand Down
11 changes: 11 additions & 0 deletions orc-rt/unittests/SPSWrapperFunctionTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,17 @@ TEST(SPSWrapperFunctionUtilsTest, TransparentConversionPointers) {
EXPECT_EQ(P, &X);
}

TEST(SPSWrapperFunctionUtilsTest, TransparentConversionReferenceArguments) {
int X = 42;
int *P = nullptr;
SPSWrapperFunction<SPSExecutorAddr(SPSExecutorAddr)>::call(
DirectCaller(nullptr, round_trip_int_pointer_sps_wrapper),
[&](Expected<int32_t *> R) { P = cantFail(std::move(R)); },
static_cast<int *const &>(&X));

EXPECT_EQ(P, &X);
}

static void
expected_int_pointer_sps_wrapper(orc_rt_SessionRef Session, void *CallCtx,
orc_rt_WrapperFunctionReturn Return,
Expand Down
Loading