Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion lldb/source/Commands/CommandObjectProtocolServer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,57 @@ class CommandObjectProtocolServerStop : public CommandObjectParsed {
}
};

class CommandObjectProtocolServerGet : public CommandObjectParsed {
public:
CommandObjectProtocolServerGet(CommandInterpreter &interpreter)
: CommandObjectParsed(interpreter, "protocol-server get",
"get protocol server connection information",
"protocol-server get <protocol>") {
AddSimpleArgumentList(lldb::eArgTypeProtocol, eArgRepeatPlain);
}

~CommandObjectProtocolServerGet() override = default;

protected:
void DoExecute(Args &args, CommandReturnObject &result) override {
if (args.GetArgumentCount() < 1) {
result.AppendError("no protocol specified");
return;
}

llvm::StringRef protocol = args.GetArgumentAtIndex(0);
ProtocolServer *server = ProtocolServer::GetOrCreate(protocol);
if (!server) {
result.AppendErrorWithFormatv(
"unsupported protocol: {0}. Supported protocols are: {1}", protocol,
llvm::join(ProtocolServer::GetSupportedProtocols(), ", "));
return;
}

Socket *socket = server->GetSocket();
if (!socket) {
result.AppendErrorWithFormatv("{0} server is not running", protocol);
return;
}

std::string address = llvm::join(socket->GetListeningConnectionURI(), ", ");
result.AppendMessageWithFormatv("{0} server connection listeners: {1}",
protocol, address);
result.SetStatus(eReturnStatusSuccessFinishNoResult);
}
};

CommandObjectProtocolServer::CommandObjectProtocolServer(
CommandInterpreter &interpreter)
: CommandObjectMultiword(interpreter, "protocol-server",
"Start and stop a protocol server.",
"Start, stop, and query protocol servers.",
"protocol-server") {
LoadSubCommand("start", CommandObjectSP(new CommandObjectProtocolServerStart(
interpreter)));
LoadSubCommand("stop", CommandObjectSP(
new CommandObjectProtocolServerStop(interpreter)));
LoadSubCommand(
"get", CommandObjectSP(new CommandObjectProtocolServerGet(interpreter)));
}

CommandObjectProtocolServer::~CommandObjectProtocolServer() = default;
1 change: 1 addition & 0 deletions lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ llvm::Error ProtocolServerMCP::Stop() {

m_server.reset(nullptr);
m_server_info_handle.Remove();
m_listener.reset();

return llvm::Error::success();
}
13 changes: 13 additions & 0 deletions lldb/test/API/commands/protocol/TestMCPUnixSocket.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,16 @@ def test_unix_socket(self):
startstr="MCP server started with connection listeners:",
substrs=[f"unix-connect://{socket_file}"],
)

self.expect(
"protocol-server get MCP",
startstr="MCP server connection listeners:",
substrs=[f"unix-connect://{socket_file}"],
)

self.runCmd("protocol-server stop MCP", check=False)
self.expect(
"protocol-server get MCP",
error=True,
substrs=["MCP server is not running"],
)
Loading