[CMake][gRPC] Update FindGRPC.cmake to support newer gRPC versions #162935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.7
cachemeifyoucan
requested review from
kadircet,
kirillbobyrev,
sam-mccall,
serge-sans-paille and
sylvestre
|
I tested on macOS, where it seems no extra settings are needed to find gRPC as long as the package is installed via HomeBrew. I don't know if there are anyone relies on the linking system library path, which obvious missing all the dependencies if using any recent gRPC version as reported in the GitHub issues linked. Maybe it can be removed. |
Created using spr 1.3.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the logic to find gRPC to always favor CMake
find_packageimplementation including for builds on macOS that uses homebrew, where
gRPCConfig.cmake is also installed to provide an accurate target
dependencies to link against.
This fixes the problem that newer gRPC version has broken up the
libraries into smaller pieces and the hard coded list of libraries in
the implementation can no longer work.
Fixes: #59844