Skip to content

[lldb][test] Fix language note tests on Windows #162995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2025
Merged

[lldb][test] Fix language note tests on Windows #162995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1d5261
[lldb][test] Fix language note tests on Windows
Michael137 Oct 11, 2025
f60be74
fixup! python format
Michael137 Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,9 @@ def check_error(diags):
# Detail 1/3: note: requested expression language
diag = details.GetItemAtIndex(0)
self.assertEqual(str(diag.GetValueForKey("severity")), "note")
self.assertEqual(
str(diag.GetValueForKey("message")), "Ran expression as 'C++11'."
)
self.assertEqual(
str(diag.GetValueForKey("rendered")), "Ran expression as 'C++11'."
self.assertIn("Ran expression as 'C++", str(diag.GetValueForKey("message")))
self.assertIn(
"Ran expression as 'C++", str(diag.GetValueForKey("rendered"))
)
self.assertEqual(str(diag.GetValueForKey("source_location")), "")
self.assertEqual(str(diag.GetValueForKey("file")), "")
Expand Down
2 changes: 1 addition & 1 deletion lldb/test/Shell/Expr/TestExprLanguageNote.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ run
expr blah

# CHECK-TARGET: (lldb) expr
# CHECK-TARGET: note: Ran expression as 'C++14'.
# CHECK-TARGET: note: Ran expression as 'C++{{.*}}'

expr -l objc -- blah

Expand Down
Loading