[APINotes] Upstream APINotesWriter #65187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorzhdan
added
the
clang:frontend
compnerd
reviewed
Sep 1, 2023
egorzhdan
force-pushed
the
upstream-apinotes-writer
branch
from
294610b to
e2150c2
Compare
egorzhdan
force-pushed
the
upstream-apinotes-writer
branch
from
e2150c2 to
a553de6
Compare
compnerd
approved these changes
Sep 4, 2023
| // Translate the selector reference into a stored selector. | ||
| StoredObjCSelector Selector; | ||
| Selector.Identifiers.reserve(SelectorRef.Identifiers.size()); | ||
| for (auto piece : SelectorRef.Identifiers) { |
There was a problem hiding this comment.
Braces aren't really needed... almost makes me prefer a std::transform.
There was a problem hiding this comment.
Done, removed the braces
This upstreams more of the Clang API Notes functionality that is currently implemented in the Apple fork: https://github.com/apple/llvm-project/tree/next/clang/lib/APINotes
egorzhdan
force-pushed
the
upstream-apinotes-writer
branch
from
a553de6 to
a3e7232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstreams more of the Clang API Notes functionality that is currently implemented in the Apple fork: https://github.com/apple/llvm-project/tree/next/clang/lib/APINotes