Skip to content

[NFC][Clang] Fix test constexpr-function-recovery-crash.cpp #65269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2023
Merged

[NFC][Clang] Fix test constexpr-function-recovery-crash.cpp #65269

merged 1 commit into from
Sep 5, 2023

Conversation

yronglin
Copy link
Contributor

@yronglin yronglin commented Sep 4, 2023

No description provided.

@yronglin
[NFC][Clang] Fix test constexpr-function-recovery-crash.cpp
1c157a6 
Signed-off-by: yronglin <yronglin777@gmail.com>
@yronglin yronglin requested a review from a team as a code owner September 4, 2023 15:07
yronglin
yronglin commented Sep 4, 2023
View reviewed changes
@philnik777 philnik777 added the clang Clang issues not falling into any other category label Sep 4, 2023
@yronglin yronglin added the clang:frontend Language frontend issues, e.g. anything involving "Sema" label Sep 4, 2023
@cor3ntin
Copy link
Contributor

cor3ntin commented Sep 4, 2023

This looks correct to me, but I'd like @sam-mccall to confirm that it was unintended.
Maybe we should keep the old code around as loops tend to share some code and we don't want if(!!;;) to crash either

sam-mccall
sam-mccall approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@sam-mccall sam-mccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't have a strong opinion about keeping the old even-more-broken versions. They're not very likely, and we don't attempt to cover most things like that. A fuzzer is probably a better approach (we have one, it finds an ~infinite number of crashes).

@yronglin
Copy link
Contributor Author

yronglin commented Sep 5, 2023

Thanks a lot for your review! @sam-mccall @cor3ntin

@yronglin yronglin merged commit 111c1ba into llvm:main Sep 5, 2023
avillega pushed a commit to avillega/llvm-project that referenced this pull request Sep 11, 2023
@yronglin
[NFC][Clang] Fix test constexpr-function-recovery-crash.cpp (llvm#65269)
1518737 
Signed-off-by: yronglin <yronglin777@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-mccall sam-mccall sam-mccall approved these changes

@hokein hokein Awaiting requested review from hokein

Assignees
No one assigned
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yronglin @cor3ntin @sam-mccall @philnik777