Skip to content

[AArch64]: Refactor target parser to use Bitset. #65423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 12, 2023
Merged

[AArch64]: Refactor target parser to use Bitset. #65423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7f28cca
[AArch64]: Refactor target parser to use BitVector.
hassnaaHamdi Sep 5, 2023
b238387
[AArch64]: Refactor target parser to use Bitset.
hassnaaHamdi Sep 7, 2023
618418d
Code Format
hassnaaHamdi Sep 7, 2023
c273f78
assert MAX extensions is divisible by 4 to correctly calc hex value o…
hassnaaHamdi Sep 8, 2023
82e11d8
fix missing replacement of AEK_EXTENTIONS_MAX
hassnaaHamdi Sep 8, 2023
b8fdc42
Resolve review comments.
hassnaaHamdi Sep 11, 2023
fb4fa9a
Resolve review comments.
hassnaaHamdi Sep 12, 2023
72b6b8c
Resolve review comments
hassnaaHamdi Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/Basic/Targets/AArch64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,7 @@ bool AArch64TargetInfo::initFeatureMap(
// Parse the CPU and add any implied features.
std::optional<llvm::AArch64::CpuInfo> CpuInfo = llvm::AArch64::parseCpu(CPU);
if (CpuInfo) {
uint64_t Exts = CpuInfo->getImpliedExtensions();
llvm::Bitset Exts = CpuInfo->getImpliedExtensions();
std::vector<StringRef> CPUFeats;
llvm::AArch64::getExtensionFeatures(Exts, CPUFeats);
for (auto F : CPUFeats) {
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/Driver/ToolChains/Arch/AArch64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ static bool DecodeAArch64Mcpu(const Driver &D, StringRef Mcpu, StringRef &CPU,

Features.push_back(ArchInfo->ArchFeature);

uint64_t Extension = CpuInfo->getImpliedExtensions();
llvm::Bitset Extension = CpuInfo->getImpliedExtensions();
if (!llvm::AArch64::getExtensionFeatures(Extension, Features))
return false;
}
Expand Down
Loading