[NFC] Update coroutine intrinsics documentation and few remaining tests to opaque pointers #65698
+184
−190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts to opaque pointers
|
I kept few no-op ptr->ptr bitcasts in order not to rename unnamed values |
nunoplopes
reviewed
Sep 8, 2023
nunoplopes
approved these changes
Sep 8, 2023
asl
added a commit
to asl/llvm-project
that referenced
this pull request
Feb 5, 2024
…ts to opaque pointers (llvm#65698)
asl
added a commit
to asl/llvm-project
that referenced
this pull request
Mar 22, 2024
rxwei
pushed a commit
to apple/llvm-project
that referenced
this pull request
Mar 27, 2024
* Update coroutine intrinsics documentation and few remaining tests to opaque pointers (llvm#65698) * Extend `retcon.once` coroutines lowering to optionally produce a normal result (llvm#66333) One of the main user of these kind of coroutines is swift. There yield-once (`retcon.once`) coroutines are used to temporary "expose" pointers to internal fields of various objects creating borrow scopes. However, in some cases it might be useful also to allow these coroutines to produce a normal result, but there is no convenient way to represent this (as compared to switched-resume kind of coroutines where C++ `co_return` is transformed to a member / callback call on promise object). The extension is simple: we allow continuation function to have a non-void result and accept optional extra arguments via a special `llvm.coro.end.result` intrinsic that would essentially forward them as normal results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.