Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMDGPU][GFX11] Add more test coverage for FMA instructions. #65935

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

kosarev
Copy link
Collaborator

@kosarev kosarev commented Sep 11, 2023

This is another attempt to update the tests to run for GFX11. Previously done in https://reviews.llvm.org/D153269, and then reverted in https://reviews.llvm.org/rG2d3e6c440244ad94777aa13566b0376eb3c088f1 due to a failure on a buildbot with expensive checks enabled. Commit 4b1702e fixed the problem.

Copy link
Contributor

@jayfoad jayfoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Sisyph
Copy link
Contributor

Sisyph commented Sep 11, 2023

Commit 79f52af fixed the problem.

This commit is from Nov 8, 2021. Maybe you linked the wrong one?

This is another attempt to update the tests to run for GFX11. Previously
done in <https://reviews.llvm.org/D153269>, and then reverted in
<https://reviews.llvm.org/rG2d3e6c440244ad94777aa13566b0376eb3c088f1> due
to a failure on a buildbot with expensive checks enabled. Commit
4b1702e fixed the problem.
@kosarev kosarev force-pushed the 2023-09-11-add_fp_conv_coverage branch from 550401c to f858b97 Compare September 11, 2023 16:11
@kosarev
Copy link
Collaborator Author

kosarev commented Sep 11, 2023

Commit 79f52af fixed the problem.
This commit is from Nov 8, 2021. Maybe you linked the wrong one?

Yep, that the one that was fixed by it, not the fix itself. Updated, thanks.

Copy link
Contributor

@Sisyph Sisyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosarev kosarev merged commit a1e38e0 into llvm:main Sep 12, 2023
1 of 2 checks passed
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
)

This is another attempt to update the tests to run for GFX11. Previously
done in <https://reviews.llvm.org/D153269>, and then reverted in
<https://reviews.llvm.org/rG2d3e6c440244ad94777aa13566b0376eb3c088f1>
due to a failure on a buildbot with expensive checks enabled. Commit
4b1702e fixed the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants