Swedev 414443 #65947
Closed
Swedev 414443 #65947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWEDEV-414443. Fixes performance regression introduced by D155343. Allows sinking in a simple case when there are no loops.
arsenm
reviewed
Sep 11, 2023
| @@ -171,6 +171,39 @@ bool SIInstrInfo::isIgnorableUse(const MachineOperand &MO) const { | |||
| isVALU(*MO.getParent()) && !resultDependsOnExec(*MO.getParent()); | |||
| } | |||
|
|
|||
| bool SIInstrInfo::modifiesRegisterImplicitly( | |||
There was a problem hiding this comment.
We have an ever growing set of convoluted callbacks to deal with this problem. I think we need to look into moving some of the modeling of this into the CFG itself. I think we need to mark block edges as convergent/divergent/something
arsenm
reviewed
Sep 11, 2023
| // SI_END_CF restores exec mask as it was before SI_IF (unchanged) | ||
| Register EndCF = ModifierInstr->getOperand(0).getReg(); | ||
| MachineInstr *SIIF = MRI.getVRegDef(EndCF); | ||
| if (SIIF->getOpcode() == AMDGPU::SI_IF && MRI.hasOneUse(EndCF) && |
There was a problem hiding this comment.
This doesn't even work after lowering
|
Description needs to be what this is doing, the swdev thing should be a comment footer |
|
Is this still relevant? I thought a newer patch fixed the same issue? |
|
Implemented in #67456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.