Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[X86] Fix an assembler bug of CMPCCXADD. #66748

Merged
merged 2 commits into from
Sep 20, 2023
Merged

[X86] Fix an assembler bug of CMPCCXADD. #66748

merged 2 commits into from
Sep 20, 2023

Conversation

FreddyLeaf
Copy link
Contributor

No description provided.

@llvmbot llvmbot added backend:X86 mc Machine (object) code labels Sep 19, 2023
phoebewang
phoebewang approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@phoebewang phoebewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

KanRobert
KanRobert approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@KanRobert KanRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FreddyLeaf FreddyLeaf merged commit cf1d2e4 into llvm:main Sep 20, 2023
2 checks passed
@FreddyLeaf FreddyLeaf deleted the asm_cmpccxadd branch September 20, 2023 13:01
This was referenced Sep 20, 2023
Closed
Closed
@kstoimenov kstoimenov mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoebewang phoebewang phoebewang approved these changes

@KanRobert KanRobert KanRobert approved these changes

@RKSimon RKSimon Awaiting requested review from RKSimon

Assignees
No one assigned
Labels
backend:X86 mc Machine (object) code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FreddyLeaf @phoebewang @KanRobert @llvmbot