Skip to content

[clang][Interp] Handle CXXScalarValueInitExprs #67147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

[clang][Interp] Handle CXXScalarValueInitExprs #67147

merged 1 commit into from
Oct 10, 2023

Conversation

tbaederr
Copy link
Contributor

No description provided.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Sep 22, 2023
tbaederr
tbaederr commented Sep 22, 2023
View reviewed changes
erichkeane
erichkeane approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@erichkeane erichkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks simple/right enough. LGTM.

shafik
shafik reviewed Sep 23, 2023
View reviewed changes
Copy link
Collaborator

@shafik shafik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I want more tests.

shafik
shafik reviewed Sep 23, 2023
View reviewed changes
Copy link
Collaborator

@shafik shafik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the additions, almost there :-)

@tbaederr tbaederr force-pushed the scalar-init branch 2 times, most recently from 163e0d9 to a64adec Compare September 29, 2023 07:41
@tbaederr
Copy link
Contributor Author

I've removed the second commit, so this needs #67229 to be merged first.

shafik
shafik approved these changes Sep 30, 2023
View reviewed changes
@tbaederr
Copy link
Contributor Author

tbaederr commented Oct 9, 2023

Ping

shafik
shafik approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@shafik shafik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fill out the description with some more details so folks reading git log will have more context,

@tbaederr tbaederr merged commit 1210738 into llvm:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shafik shafik shafik approved these changes

@erichkeane erichkeane erichkeane approved these changes

@cor3ntin cor3ntin Awaiting requested review from cor3ntin

@AaronBallman AaronBallman Awaiting requested review from AaronBallman

Assignees
No one assigned
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tbaederr @shafik @erichkeane @llvmbot