Skip to content

[TargetLowering] remove unused virtual from ComputeConstraintToUse #67171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[TargetLowering] remove unused virtual from ComputeConstraintToUse #67171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c3b4b1
[TargetLowering] remove unused virtual from ComputeConstraintToUse
nickdesaulniers Sep 22, 2023
ca60960
fix up llvm-extract
nickdesaulniers Sep 25, 2023
ebe1913
fix Polly unittests unresolved symbols errors on Windows
nickdesaulniers Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions llvm/include/llvm/CodeGen/TargetLowering.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4842,9 +4842,8 @@ class TargetLowering : public TargetLoweringBase {
/// AsmOperandInfo, setting OpInfo.ConstraintCode and OpInfo.ConstraintType.
/// If the actual operand being passed in is available, it can be passed in as
/// Op, otherwise an empty SDValue can be passed.
virtual void ComputeConstraintToUse(AsmOperandInfo &OpInfo,
SDValue Op,
SelectionDAG *DAG = nullptr) const;
void ComputeConstraintToUse(AsmOperandInfo &OpInfo, SDValue Op,
SelectionDAG *DAG = nullptr) const;

/// Given a constraint, return the type of constraint it is for this target.
virtual ConstraintType getConstraintType(StringRef Constraint) const;
Expand Down
3 changes: 2 additions & 1 deletion llvm/tools/llvm-extract/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ set(LLVM_LINK_COMPONENTS
BitWriter
Core
IPO
IRReader
IRPrinter
IRReader
Passes
SelectionDAG
Support
)

Expand Down
3 changes: 2 additions & 1 deletion llvm/unittests/Analysis/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@ set(LLVM_LINK_COMPONENTS
Analysis
AsmParser
Core
IPO
Passes
SelectionDAG
Support
TargetParser
TransformUtils
IPO
)

set(ANALYSIS_TEST_SOURCES
Expand Down
2 changes: 1 addition & 1 deletion llvm/unittests/Passes/Plugins/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# work with DLLs on Windows (where a shared library can't have undefined
# references), so just skip this testcase on Windows.
if (NOT WIN32 AND NOT CYGWIN)
set(LLVM_LINK_COMPONENTS Support Passes Core AsmParser)
set(LLVM_LINK_COMPONENTS Support Passes Core AsmParser SelectionDAG)
add_llvm_unittest(PluginsTests
PluginsTest.cpp
)
Expand Down
1 change: 1 addition & 0 deletions polly/unittests/DeLICM/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Solaris ld requires this dependency to be made explicit for shared builds.
set(LLVM_LINK_COMPONENTS
Core
SelectionDAG
)

add_polly_unittest(DeLICMTests
Expand Down
3 changes: 3 additions & 0 deletions polly/unittests/ScheduleOptimizer/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
set(LLVM_LINK_COMPONENTS
SelectionDAG
)
add_polly_unittest(ScheduleOptimizerTests
ScheduleTreeTransformTest.cpp
)
3 changes: 3 additions & 0 deletions polly/unittests/ScopPassManager/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
set(LLVM_LINK_COMPONENTS
SelectionDAG
)
add_polly_unittest(ScopPassManagerTests
PassManagerTest.cpp
)
Expand Down