Skip to content

Conversation

boomanaiden154
Copy link
Contributor

These pages have warnings due to the links not being moved during the myst transition and maybe some breakages afterwards. This causes the docs build to fail as warnings are treated as errors by default. This patch fixes these issues for llvm/*.

These pages have warnings due to the links not being moved during the
myst transition and maybe some breakages afterwards. This causes the
docs build to fail as warnings are treated as errors by default. This
patch fixes these issues for llvm/*.
Copy link
Contributor

@cor3ntin cor3ntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test the changes locally?
Looking at the doc I would think that it would expect a slug, ie project:DeveloperPolicy.rst#adding-an-established-project-to-the-llvm-monorepo, but maybe not?

@boomanaiden154
Copy link
Contributor Author

Did you test the changes locally? Looking at the doc I would think that it would expect a slug, ie project:DeveloperPolicy.rst#adding-an-established-project-to-the-llvm-monorepo, but maybe not?

I did test them locally and this fixes all the issues. Not sure exactly why this works. I did try the slug and couldn't get it to work, but maybe I wasn't doing it correctly.

Copy link
Contributor

@cor3ntin cor3ntin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit weird but if it builds I'm happy to accept the PR as is to fix the build!
Thanks for the fix

@boomanaiden154 boomanaiden154 merged commit d97947e into llvm:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants