Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT][RISCV] Don't create function entry points for unnamed symbols #68977

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

mtvec
Copy link
Contributor

@mtvec mtvec commented Oct 13, 2023

Unnamed symbols are used, for example, for debug info related relocations on RISC-V.

Unnamed symbols are used, for example, for debug info related
relocations on RISC-V.
@github-actions
Copy link

github-actions bot commented Oct 13, 2023

✅ With the latest revision this PR passed the C/C++ code formatter.

@yota9
Copy link
Member

yota9 commented Oct 13, 2023

LG, although for now I'd prefer to add RISCV condition, since we don't expect this on other platforms

@mtvec mtvec changed the title [BOLT] Don't create function entry points for unnamed symbols [BOLT][RISCV] Don't create function entry points for unnamed symbols Oct 16, 2023
Copy link
Member

@yota9 yota9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@mtvec mtvec merged commit c67b862 into llvm:main Oct 16, 2023
3 checks passed
MaskRay added a commit that referenced this pull request Apr 26, 2024
The special case is unneeded after #89693.

Pull Request: #90004
@joker-eph
Copy link
Collaborator

Some mid-air conflict led to this breaking the tests apparently!
https://lab.llvm.org/buildbot/#/builders/272/builds/15023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants