Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X86] Remove unused function createX86PreAMXConfigPass #69547

Conversation

kazutakahirata
Copy link
Contributor

The last use was removed by:

commit 496156a
Author: Luo, Yuanke yuanke.luo@intel.com
Date: Tue May 3 18:57:25 2022 +0800

The last use was removed by:

  commit 496156a
  Author: Luo, Yuanke <yuanke.luo@intel.com>
  Date:   Tue May 3 18:57:25 2022 +0800
@llvmbot
Copy link
Collaborator

llvmbot commented Oct 19, 2023

@llvm/pr-subscribers-backend-x86

Author: Kazu Hirata (kazutakahirata)

Changes

The last use was removed by:

commit 496156a
Author: Luo, Yuanke <yuanke.luo@intel.com>
Date: Tue May 3 18:57:25 2022 +0800


Full diff: https://github.com/llvm/llvm-project/pull/69547.diff

2 Files Affected:

  • (modified) llvm/include/llvm/CodeGen/Passes.h (-3)
  • (modified) llvm/lib/Target/X86/X86PreAMXConfig.cpp (-4)
diff --git a/llvm/include/llvm/CodeGen/Passes.h b/llvm/include/llvm/CodeGen/Passes.h
index 598c0b838c1b97d..8d14eef949e91b4 100644
--- a/llvm/include/llvm/CodeGen/Passes.h
+++ b/llvm/include/llvm/CodeGen/Passes.h
@@ -584,9 +584,6 @@ namespace llvm {
   /// or split the data to two <128 x i32>.
   FunctionPass *createX86LowerAMXTypePass();
 
-  /// The pass insert tile config intrinsics for AMX fast register allocation.
-  FunctionPass *createX86PreAMXConfigPass();
-
   /// The pass transforms amx intrinsics to scalar operation if the function has
   /// optnone attribute or it is O0.
   FunctionPass *createX86LowerAMXIntrinsicsPass();
diff --git a/llvm/lib/Target/X86/X86PreAMXConfig.cpp b/llvm/lib/Target/X86/X86PreAMXConfig.cpp
index 7872a64061d438c..078c269277cbbe8 100644
--- a/llvm/lib/Target/X86/X86PreAMXConfig.cpp
+++ b/llvm/lib/Target/X86/X86PreAMXConfig.cpp
@@ -409,7 +409,3 @@ char X86PreAMXConfigPass::ID = 0;
 INITIALIZE_PASS_BEGIN(X86PreAMXConfigPass, DEBUG_TYPE, PassName, false, false)
 INITIALIZE_PASS_DEPENDENCY(TargetPassConfig)
 INITIALIZE_PASS_END(X86PreAMXConfigPass, DEBUG_TYPE, PassName, false, false)
-
-FunctionPass *llvm::createX86PreAMXConfigPass() {
-  return new X86PreAMXConfigPass();
-}

@yubingex007-a11y
Copy link
Contributor

wait let me run all the AMX testcases first before merging the pr.

@yubingex007-a11y
Copy link
Contributor

yubingex007-a11y commented Oct 19, 2023

i saw https://reviews.llvm.org/D125075 deleted X86PreAMXConfigPass in O0's PM and let O0 use X86FastPreTileConfigPass to insert ldtilecfg. i think we can safely remove X86PreAMXConfigPass 's related code.

i am WIP on that thing: #69569.
lets merge #69569. instead of current pr.

@kazutakahirata
Copy link
Contributor Author

i am WIP on that thing: #69569. lets merge #69569. instead of current pr.

Sounds good. Thank you for going the extra mile and removing the whole pass! I'm closing this PR.

@kazutakahirata kazutakahirata deleted the cleanup_dead_function_createX86PreAMXConfigPass branch October 20, 2023 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants