[clangd] update list of fast tidy checks #69723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new fast checks: bugprone-compare-pointer-to-member-variable bugprone-empty-catch bugprone-inc-dec-in-conditions bugprone-incorrect-enable-if bugprone-multi-level-implicit-pointer-conversion bugprone-multiple-new-in-one-expression bugprone-non-zero-enum-to-bool-conversion bugprone-optional-value-conversion bugprone-standalone-empty bugprone-switch-missing-default-case bugprone-unique-ptr-array-mismatch bugprone-unsafe-functions cert-msc24-c cert-msc33-c cppcoreguidelines-avoid-capturing-lambda-coroutines cppcoreguidelines-avoid-reference-coroutine-parameters cppcoreguidelines-macro-to-enum cppcoreguidelines-misleading-capture-default cppcoreguidelines-missing-std-forward cppcoreguidelines-no-suspend-with-lock cppcoreguidelines-noexcept-destructor cppcoreguidelines-noexcept-move-operations cppcoreguidelines-noexcept-swap cppcoreguidelines-rvalue-reference-param-not-moved cppcoreguidelines-use-default-member-init llvmlibc-inline-function-decl misc-coroutine-hostile-raii misc-include-cleaner misc-use-anonymous-namespace modernize-type-traits modernize-use-constraints modernize-use-std-print performance-avoid-endl performance-enum-size performance-noexcept-cdestructor performance-noexcept-swap readability-operators-representation readibility-reference-to-constructed-temporary new slow checks: misc-header-include-cycle no checks changed between fast and slow
|
@llvm/pr-subscribers-clangd Author: Sam McCall (sam-mccall) Changesnew fast checks: new slow checks: no checks changed between fast and slow Patch is 28.80 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/69723.diff 1 Files Affected:
diff --git a/clang-tools-extra/clangd/TidyFastChecks.inc b/clang-tools-extra/clangd/TidyFastChecks.inc
index 9596ba4d725b650..6f358921bd7fcc1 100644
--- a/clang-tools-extra/clangd/TidyFastChecks.inc
+++ b/clang-tools-extra/clangd/TidyFastChecks.inc
@@ -7,372 +7,413 @@
#define SLOW(CHECK, DELTA)
#endif
-FAST(abseil-cleanup-ctad, -1.0)
-FAST(abseil-duration-addition, 0.0)
-FAST(abseil-duration-comparison, 1.0)
+FAST(abseil-cleanup-ctad, 0.0)
+FAST(abseil-duration-addition, 1.0)
+FAST(abseil-duration-comparison, 4.0)
FAST(abseil-duration-conversion-cast, 3.0)
-FAST(abseil-duration-division, -0.0)
-FAST(abseil-duration-factory-float, 1.0)
-FAST(abseil-duration-factory-scale, -0.0)
-FAST(abseil-duration-subtraction, 1.0)
-FAST(abseil-duration-unnecessary-conversion, 4.0)
-FAST(abseil-faster-strsplit-delimiter, 2.0)
-FAST(abseil-no-internal-dependencies, -1.0)
-FAST(abseil-no-namespace, -1.0)
-FAST(abseil-redundant-strcat-calls, 2.0)
-FAST(abseil-str-cat-append, 1.0)
-FAST(abseil-string-find-startswith, 1.0)
-FAST(abseil-string-find-str-contains, 1.0)
-FAST(abseil-time-comparison, -0.0)
-FAST(abseil-time-subtraction, 0.0)
+FAST(abseil-duration-division, 1.0)
+FAST(abseil-duration-factory-float, -0.0)
+FAST(abseil-duration-factory-scale, 1.0)
+FAST(abseil-duration-subtraction, -1.0)
+FAST(abseil-duration-unnecessary-conversion, 1.0)
+FAST(abseil-faster-strsplit-delimiter, -1.0)
+FAST(abseil-no-internal-dependencies, 0.0)
+FAST(abseil-no-namespace, 1.0)
+FAST(abseil-redundant-strcat-calls, 1.0)
+FAST(abseil-str-cat-append, -1.0)
+FAST(abseil-string-find-startswith, 0.0)
+FAST(abseil-string-find-str-contains, -1.0)
+FAST(abseil-time-comparison, 0.0)
+FAST(abseil-time-subtraction, 2.0)
FAST(abseil-upgrade-duration-conversions, 2.0)
SLOW(altera-id-dependent-backward-branch, 13.0)
-FAST(altera-kernel-name-restriction, -1.0)
-FAST(altera-single-work-item-barrier, -1.0)
-FAST(altera-struct-pack-align, -1.0)
-FAST(altera-unroll-loops, 2.0)
-FAST(android-cloexec-accept, -1.0)
-FAST(android-cloexec-accept4, 3.0)
-FAST(android-cloexec-creat, 0.0)
-FAST(android-cloexec-dup, 3.0)
-FAST(android-cloexec-epoll-create, -2.0)
-FAST(android-cloexec-epoll-create1, -1.0)
-FAST(android-cloexec-fopen, -0.0)
-FAST(android-cloexec-inotify-init, 1.0)
-FAST(android-cloexec-inotify-init1, 2.0)
-FAST(android-cloexec-memfd-create, 2.0)
-FAST(android-cloexec-open, -1.0)
+FAST(altera-kernel-name-restriction, 0.0)
+FAST(altera-single-work-item-barrier, 1.0)
+FAST(altera-struct-pack-align, 0.0)
+FAST(altera-unroll-loops, 1.0)
+FAST(android-cloexec-accept, 1.0)
+FAST(android-cloexec-accept4, -1.0)
+FAST(android-cloexec-creat, 1.0)
+FAST(android-cloexec-dup, 0.0)
+FAST(android-cloexec-epoll-create, 3.0)
+FAST(android-cloexec-epoll-create1, 2.0)
+FAST(android-cloexec-fopen, 0.0)
+FAST(android-cloexec-inotify-init, -1.0)
+FAST(android-cloexec-inotify-init1, 1.0)
+FAST(android-cloexec-memfd-create, -2.0)
+FAST(android-cloexec-open, -0.0)
FAST(android-cloexec-pipe, -1.0)
-FAST(android-cloexec-pipe2, 0.0)
-FAST(android-cloexec-socket, 1.0)
-FAST(android-comparison-in-temp-failure-retry, 0.0)
-FAST(boost-use-to-string, 1.0)
-FAST(bugprone-argument-comment, 2.0)
+FAST(android-cloexec-pipe2, 2.0)
+FAST(android-cloexec-socket, 2.0)
+FAST(android-comparison-in-temp-failure-retry, 1.0)
+FAST(boost-use-to-string, -0.0)
+FAST(bugprone-argument-comment, 1.0)
FAST(bugprone-assert-side-effect, 1.0)
-FAST(bugprone-assignment-in-if-condition, -0.0)
-FAST(bugprone-bad-signal-to-kill-thread, -1.0)
-FAST(bugprone-bool-pointer-implicit-conversion, 0.0)
-FAST(bugprone-branch-clone, -0.0)
+FAST(bugprone-assignment-in-if-condition, 0.0)
+FAST(bugprone-bad-signal-to-kill-thread, 0.0)
+FAST(bugprone-bool-pointer-implicit-conversion, 3.0)
+FAST(bugprone-branch-clone, 0.0)
+FAST(bugprone-compare-pointer-to-member-virtual-function, -1.0)
FAST(bugprone-copy-constructor-init, 1.0)
-FAST(bugprone-dangling-handle, 0.0)
-FAST(bugprone-dynamic-static-initializers, 1.0)
-FAST(bugprone-easily-swappable-parameters, 2.0)
-FAST(bugprone-exception-escape, 1.0)
-FAST(bugprone-fold-init-type, 2.0)
-FAST(bugprone-forward-declaration-namespace, 0.0)
-FAST(bugprone-forwarding-reference-overload, -0.0)
-FAST(bugprone-implicit-widening-of-multiplication-result, 3.0)
-FAST(bugprone-inaccurate-erase, -0.0)
-FAST(bugprone-incorrect-roundings, 1.0)
-FAST(bugprone-infinite-loop, 4.0)
-FAST(bugprone-integer-division, -3.0)
-FAST(bugprone-lambda-function-name, 1.0)
-FAST(bugprone-macro-parentheses, 8.0)
-FAST(bugprone-macro-repeated-side-effects, 1.0)
-FAST(bugprone-misplaced-operator-in-strlen-in-alloc, -0.0)
-FAST(bugprone-misplaced-pointer-arithmetic-in-alloc, 2.0)
-FAST(bugprone-misplaced-widening-cast, -2.0)
-FAST(bugprone-move-forwarding-reference, -2.0)
+FAST(bugprone-dangling-handle, -1.0)
+FAST(bugprone-dynamic-static-initializers, -0.0)
+FAST(bugprone-easily-swappable-parameters, 3.0)
+FAST(bugprone-empty-catch, 2.0)
+FAST(bugprone-exception-escape, -0.0)
+FAST(bugprone-fold-init-type, -1.0)
+FAST(bugprone-forward-declaration-namespace, -1.0)
+FAST(bugprone-forwarding-reference-overload, -1.0)
+FAST(bugprone-implicit-widening-of-multiplication-result, 2.0)
+FAST(bugprone-inaccurate-erase, 2.0)
+FAST(bugprone-inc-dec-in-conditions, 3.0)
+FAST(bugprone-incorrect-enable-if, 1.0)
+FAST(bugprone-incorrect-roundings, 2.0)
+FAST(bugprone-infinite-loop, 3.0)
+FAST(bugprone-integer-division, 0.0)
+FAST(bugprone-lambda-function-name, -1.0)
+FAST(bugprone-macro-parentheses, 1.0)
+FAST(bugprone-macro-repeated-side-effects, 0.0)
+FAST(bugprone-misplaced-operator-in-strlen-in-alloc, 1.0)
+FAST(bugprone-misplaced-pointer-arithmetic-in-alloc, 1.0)
+FAST(bugprone-misplaced-widening-cast, 0.0)
+FAST(bugprone-move-forwarding-reference, 1.0)
+FAST(bugprone-multi-level-implicit-pointer-conversion, 1.0)
+FAST(bugprone-multiple-new-in-one-expression, 1.0)
FAST(bugprone-multiple-statement-macro, 1.0)
-FAST(bugprone-narrowing-conversions, -1.0)
-FAST(bugprone-no-escape, 3.0)
-FAST(bugprone-not-null-terminated-result, 4.0)
-FAST(bugprone-parent-virtual-call, 2.0)
-FAST(bugprone-posix-return, 0.0)
-FAST(bugprone-redundant-branch-condition, 0.0)
-FAST(bugprone-reserved-identifier, 2.0)
-FAST(bugprone-shared-ptr-array-mismatch, 0.0)
-FAST(bugprone-signal-handler, -0.0)
+FAST(bugprone-narrowing-conversions, 2.0)
+FAST(bugprone-no-escape, 0.0)
+FAST(bugprone-non-zero-enum-to-bool-conversion, 1.0)
+FAST(bugprone-not-null-terminated-result, 1.0)
+FAST(bugprone-optional-value-conversion, 0.0)
+FAST(bugprone-parent-virtual-call, -1.0)
+FAST(bugprone-posix-return, -2.0)
+FAST(bugprone-redundant-branch-condition, 1.0)
+FAST(bugprone-reserved-identifier, 1.0)
+FAST(bugprone-shared-ptr-array-mismatch, -1.0)
+FAST(bugprone-signal-handler, 0.0)
FAST(bugprone-signed-char-misuse, 1.0)
FAST(bugprone-sizeof-container, -0.0)
FAST(bugprone-sizeof-expression, 0.0)
-FAST(bugprone-spuriously-wake-up-functions, 3.0)
-FAST(bugprone-string-constructor, 1.0)
+FAST(bugprone-spuriously-wake-up-functions, 1.0)
+FAST(bugprone-standalone-empty, 6.0)
+FAST(bugprone-string-constructor, -2.0)
FAST(bugprone-string-integer-assignment, 1.0)
-FAST(bugprone-string-literal-with-embedded-nul, 0.0)
-FAST(bugprone-stringview-nullptr, 2.0)
-FAST(bugprone-suspicious-enum-usage, -0.0)
-FAST(bugprone-suspicious-include, 1.0)
-FAST(bugprone-suspicious-memory-comparison, 0.0)
-FAST(bugprone-suspicious-memset-usage, 2.0)
-FAST(bugprone-suspicious-missing-comma, 0.0)
-FAST(bugprone-suspicious-realloc-usage, 1.0)
-FAST(bugprone-suspicious-semicolon, 0.0)
-FAST(bugprone-suspicious-string-compare, 2.0)
-FAST(bugprone-swapped-arguments, 0.0)
-FAST(bugprone-terminating-continue, 2.0)
-FAST(bugprone-throw-keyword-missing, -1.0)
+FAST(bugprone-string-literal-with-embedded-nul, 1.0)
+FAST(bugprone-stringview-nullptr, 3.0)
+FAST(bugprone-suspicious-enum-usage, 1.0)
+FAST(bugprone-suspicious-include, 0.0)
+FAST(bugprone-suspicious-memory-comparison, 1.0)
+FAST(bugprone-suspicious-memset-usage, 1.0)
+FAST(bugprone-suspicious-missing-comma, -0.0)
+FAST(bugprone-suspicious-realloc-usage, -1.0)
+FAST(bugprone-suspicious-semicolon, 2.0)
+FAST(bugprone-suspicious-string-compare, 1.0)
+FAST(bugprone-swapped-arguments, -0.0)
+FAST(bugprone-switch-missing-default-case, 1.0)
+FAST(bugprone-terminating-continue, 0.0)
+FAST(bugprone-throw-keyword-missing, 2.0)
FAST(bugprone-too-small-loop-variable, 0.0)
-FAST(bugprone-unchecked-optional-access, 1.0)
+FAST(bugprone-unchecked-optional-access, 2.0)
FAST(bugprone-undefined-memory-manipulation, 1.0)
FAST(bugprone-undelegated-constructor, 0.0)
-FAST(bugprone-unhandled-exception-at-new, 0.0)
-FAST(bugprone-unhandled-self-assignment, 0.0)
-FAST(bugprone-unused-raii, 2.0)
-FAST(bugprone-unused-return-value, 0.0)
-FAST(bugprone-use-after-move, 5.0)
-FAST(bugprone-virtual-near-miss, 0.0)
+FAST(bugprone-unhandled-exception-at-new, -1.0)
+FAST(bugprone-unhandled-self-assignment, 1.0)
+FAST(bugprone-unique-ptr-array-mismatch, -0.0)
+FAST(bugprone-unsafe-functions, 0.0)
+FAST(bugprone-unused-raii, 1.0)
+FAST(bugprone-unused-return-value, 3.0)
+FAST(bugprone-use-after-move, 4.0)
+FAST(bugprone-virtual-near-miss, 1.0)
FAST(cert-con36-c, 2.0)
-FAST(cert-con54-cpp, 3.0)
-FAST(cert-dcl03-c, 2.0)
-FAST(cert-dcl16-c, -1.0)
-FAST(cert-dcl21-cpp, 0.0)
-FAST(cert-dcl37-c, 3.0)
-FAST(cert-dcl50-cpp, -1.0)
+FAST(cert-con54-cpp, 2.0)
+FAST(cert-dcl03-c, 0.0)
+FAST(cert-dcl16-c, 4.0)
+FAST(cert-dcl21-cpp, -0.0)
+FAST(cert-dcl37-c, 1.0)
+FAST(cert-dcl50-cpp, -0.0)
FAST(cert-dcl51-cpp, 1.0)
-FAST(cert-dcl54-cpp, 0.0)
+FAST(cert-dcl54-cpp, -2.0)
FAST(cert-dcl58-cpp, 1.0)
FAST(cert-dcl59-cpp, 0.0)
-FAST(cert-env33-c, -1.0)
-FAST(cert-err09-cpp, 1.0)
-FAST(cert-err33-c, 4.0)
-FAST(cert-err34-c, 0.0)
-FAST(cert-err52-cpp, 1.0)
-FAST(cert-err58-cpp, 0.0)
-FAST(cert-err60-cpp, 0.0)
-FAST(cert-err61-cpp, -0.0)
-FAST(cert-exp42-c, 0.0)
-FAST(cert-fio38-c, 1.0)
-FAST(cert-flp30-c, 0.0)
-FAST(cert-flp37-c, 1.0)
+FAST(cert-env33-c, -0.0)
+FAST(cert-err09-cpp, -1.0)
+FAST(cert-err33-c, 3.0)
+FAST(cert-err34-c, 1.0)
+FAST(cert-err52-cpp, 0.0)
+FAST(cert-err58-cpp, -2.0)
+FAST(cert-err60-cpp, 1.0)
+FAST(cert-err61-cpp, -2.0)
+FAST(cert-exp42-c, 2.0)
+FAST(cert-fio38-c, -0.0)
+FAST(cert-flp30-c, 2.0)
+FAST(cert-flp37-c, 0.0)
FAST(cert-mem57-cpp, 0.0)
-FAST(cert-msc30-c, -0.0)
-FAST(cert-msc32-c, 1.0)
-FAST(cert-msc50-cpp, -1.0)
-FAST(cert-msc51-cpp, 1.0)
-FAST(cert-msc54-cpp, -1.0)
-FAST(cert-oop11-cpp, 1.0)
-FAST(cert-oop54-cpp, -0.0)
+FAST(cert-msc24-c, -1.0)
+FAST(cert-msc30-c, 0.0)
+FAST(cert-msc32-c, 0.0)
+FAST(cert-msc33-c, -2.0)
+FAST(cert-msc50-cpp, 2.0)
+FAST(cert-msc51-cpp, -1.0)
+FAST(cert-msc54-cpp, 1.0)
+FAST(cert-oop11-cpp, 2.0)
+FAST(cert-oop54-cpp, -3.0)
FAST(cert-oop57-cpp, 1.0)
-FAST(cert-oop58-cpp, 0.0)
-FAST(cert-pos44-c, 0.0)
-FAST(cert-pos47-c, -0.0)
-FAST(cert-sig30-c, 2.0)
+FAST(cert-oop58-cpp, 2.0)
+FAST(cert-pos44-c, -1.0)
+FAST(cert-pos47-c, -2.0)
+FAST(cert-sig30-c, -1.0)
FAST(cert-str34-c, 0.0)
FAST(concurrency-mt-unsafe, 3.0)
FAST(concurrency-thread-canceltype-asynchronous, 1.0)
-FAST(cppcoreguidelines-avoid-c-arrays, 2.0)
-FAST(cppcoreguidelines-avoid-const-or-ref-data-members, 1.0)
-FAST(cppcoreguidelines-avoid-do-while, -2.0)
-FAST(cppcoreguidelines-avoid-goto, 2.0)
+FAST(cppcoreguidelines-avoid-c-arrays, 1.0)
+FAST(cppcoreguidelines-avoid-capturing-lambda-coroutines, 0.0)
+FAST(cppcoreguidelines-avoid-const-or-ref-data-members, 0.0)
+FAST(cppcoreguidelines-avoid-do-while, 0.0)
+FAST(cppcoreguidelines-avoid-goto, 1.0)
FAST(cppcoreguidelines-avoid-magic-numbers, 1.0)
-FAST(cppcoreguidelines-avoid-non-const-global-variables, -0.0)
+FAST(cppcoreguidelines-avoid-non-const-global-variables, -4.0)
+FAST(cppcoreguidelines-avoid-reference-coroutine-parameters, -1.0)
FAST(cppcoreguidelines-c-copy-assignment-signature, 1.0)
-FAST(cppcoreguidelines-explicit-virtual-functions, -1.0)
-FAST(cppcoreguidelines-init-variables, 2.0)
-FAST(cppcoreguidelines-interfaces-global-init, -1.0)
-FAST(cppcoreguidelines-macro-usage, 2.0)
-FAST(cppcoreguidelines-narrowing-conversions, -2.0)
-FAST(cppcoreguidelines-no-malloc, -1.0)
-FAST(cppcoreguidelines-non-private-member-variables-in-classes, -0.0)
+FAST(cppcoreguidelines-explicit-virtual-functions, 0.0)
+FAST(cppcoreguidelines-init-variables, -1.0)
+FAST(cppcoreguidelines-interfaces-global-init, 1.0)
+FAST(cppcoreguidelines-macro-to-enum, 1.0)
+FAST(cppcoreguidelines-macro-usage, 1.0)
+FAST(cppcoreguidelines-misleading-capture-default-by-value, 1.0)
+FAST(cppcoreguidelines-missing-std-forward, 1.0)
+FAST(cppcoreguidelines-narrowing-conversions, 3.0)
+FAST(cppcoreguidelines-no-malloc, 1.0)
+FAST(cppcoreguidelines-no-suspend-with-lock, -0.0)
+FAST(cppcoreguidelines-noexcept-destructor, 0.0)
+FAST(cppcoreguidelines-noexcept-move-operations, -0.0)
+FAST(cppcoreguidelines-noexcept-swap, -0.0)
+FAST(cppcoreguidelines-non-private-member-variables-in-classes, 0.0)
FAST(cppcoreguidelines-owning-memory, 3.0)
-FAST(cppcoreguidelines-prefer-member-initializer, 1.0)
+FAST(cppcoreguidelines-prefer-member-initializer, 2.0)
FAST(cppcoreguidelines-pro-bounds-array-to-pointer-decay, 3.0)
-FAST(cppcoreguidelines-pro-bounds-constant-array-index, 3.0)
-FAST(cppcoreguidelines-pro-bounds-pointer-arithmetic, 0.0)
-FAST(cppcoreguidelines-pro-type-const-cast, 1.0)
-FAST(cppcoreguidelines-pro-type-cstyle-cast, -1.0)
-FAST(cppcoreguidelines-pro-type-member-init, 1.0)
-FAST(cppcoreguidelines-pro-type-reinterpret-cast, 2.0)
-FAST(cppcoreguidelines-pro-type-static-cast-downcast, 0.0)
+FAST(cppcoreguidelines-pro-bounds-constant-array-index, 1.0)
+FAST(cppcoreguidelines-pro-bounds-pointer-arithmetic, -0.0)
+FAST(cppcoreguidelines-pro-type-const-cast, -1.0)
+FAST(cppcoreguidelines-pro-type-cstyle-cast, -0.0)
+FAST(cppcoreguidelines-pro-type-member-init, 0.0)
+FAST(cppcoreguidelines-pro-type-reinterpret-cast, -0.0)
+FAST(cppcoreguidelines-pro-type-static-cast-downcast, 1.0)
FAST(cppcoreguidelines-pro-type-union-access, 1.0)
-FAST(cppcoreguidelines-pro-type-vararg, 1.0)
-FAST(cppcoreguidelines-slicing, 3.0)
-FAST(cppcoreguidelines-special-member-functions, -1.0)
+FAST(cppcoreguidelines-pro-type-vararg, 0.0)
+FAST(cppcoreguidelines-rvalue-reference-param-not-moved, -2.0)
+FAST(cppcoreguidelines-slicing, 4.0)
+FAST(cppcoreguidelines-special-member-functions, 0.0)
+FAST(cppcoreguidelines-use-default-member-init, 1.0)
FAST(cppcoreguidelines-virtual-class-destructor, 0.0)
-FAST(darwin-avoid-spinlock, 1.0)
+FAST(darwin-avoid-spinlock, 0.0)
FAST(darwin-dispatch-once-nonstatic, -0.0)
-FAST(fuchsia-default-arguments-calls, 2.0)
-FAST(fuchsia-default-arguments-declarations, -0.0)
-FAST(fuchsia-header-anon-namespaces, -0.0)
-FAST(fuchsia-multiple-inheritance, -1.0)
-FAST(fuchsia-overloaded-operator, -0.0)
+FAST(fuchsia-default-arguments-calls, 1.0)
+FAST(fuchsia-default-arguments-declarations, -1.0)
+FAST(fuchsia-header-anon-namespaces, 0.0)
+FAST(fuchsia-multiple-inheritance, -0.0)
+FAST(fuchsia-overloaded-operator, 0.0)
FAST(fuchsia-statically-constructed-objects, -0.0)
-FAST(fuchsia-trailing-return, 2.0)
-FAST(fuchsia-virtual-inheritance, 1.0)
-FAST(google-build-explicit-make-pair, 2.0)
-FAST(google-build-namespaces, -1.0)
-FAST(google-build-using-namespace, 0.0)
+FAST(fuchsia-trailing-return, 0.0)
+FAST(fuchsia-virtual-inheritance, 0.0)
+FAST(google-build-explicit-make-pair, 1.0)
+FAST(google-build-namespaces, 1.0)
+FAST(google-build-using-namespace, -0.0)
FAST(google-default-arguments, 1.0)
-FAST(google-explicit-constructor, 2.0)
-FAST(google-global-names-in-headers, -1.0)
-FAST(google-objc-avoid-nsobject-new, 1.0)
-FAST(google-objc-avoid-throwing-exception, 1.0)
-FAST(google-objc-function-naming, 1.0)
-FAST(google-objc-global-variable-declaration, -0.0)
-FAST(google-readability-avoid-underscore-in-googletest-name, -0.0)
-FAST(google-readability-braces-around-statements, 1.0)
+FAST(google-explicit-constructor, 1.0)
+FAST(google-global-names-in-headers, 1.0)
+FAST(google-objc-avoid-nsobject-new, -0.0)
+FAST(google-objc-avoid-throwing-exception, -0.0)
+FAST(google-objc-function-naming, -0.0)
+FAST(google-objc-global-variable-declaration, -1.0)
+FAST(google-readability-avoid-underscore-in-googletest-name, 0.0)
+FAST(google-readability-braces-around-statements, -1.0)
FAST(google-readability-casting, 1.0)
FAST(google-readability-function-size, 0.0)
FAST(google-readability-namespace-comments, 0.0)
-FAST(google-readability-todo, 1.0)
-FAST(google-runtime-int, -1.0)
-FAST(google-runtime-operator, -0.0)
-FAST(google-upgrade-googletest-case, 0.0)
+FAST(google-readability-todo, -0.0)
+FAST(google-runtime-int, 1.0)
+FAST(google-runtime-operator, 0.0)
+FAST(google-upgrade-googletest-case, 2.0)
FAST(hicpp-avoid-c-arrays, 1.0)
FAST(hicpp-avoid-goto, 0.0)
-FAST(hicpp-braces-around-statements, 1.0)
-FAST(hicpp-deprecated-headers, -1.0)
-FAST(hicpp-exception-baseclass, 0.0)
-FAST(hicpp-explicit-conversions, -1.0)
+FAST(hicpp-braces-around-statements, -0.0)
+FAST(hicpp-deprecated-headers, -0.0)
+FAST(hicpp-exception-baseclass, 1.0)
+FAST(hicpp-explicit-conversions, 1.0)
FAST(hicpp-function-size, 1.0)
-FAST(hicpp-invalid-access-moved, 6.0)
-FAST(hicpp-member-init, 2.0)
-FAST(hicpp-move-const-arg, 1.0)
-FAST(hicpp-multiway-paths-covered, 3.0)
-FAST(hicpp-named-parameter, 1.0)
-FAST(hicpp-new-delete-operators, 0.0)
-FAST(hicpp-no-array-decay, 3.0)
+FAST(hicpp-invalid-access-moved, 4.0)
+FAST(hicpp-member-init, 0.0)
+FAST(hicpp-move-const-arg, 3.0)
+FAST(hicpp-multiway-paths-covered, 1.0)
+FAST(hicpp-named-parameter, -0.0)
+FAST(hicpp-new-delete-operators, 1.0)
+FAST(hicpp-no-array-decay, 4.0)
FAST(hicpp-no-assembler, -0.0)
FAST(hicpp-no-malloc, 1.0)
-FAST(hicpp-noexcept-move, -0.0)
-FAST(hicpp-signed-bitwise, 0.0)
-FAST(hicpp-special-member-functions, 0.0)
-FAST(hicpp-static-assert, 1.0)
-FAST(hicpp-undelegated-constructor, 3.0)
-FAST(hicpp-uppercase-literal-suffix, 3.0)
-FAST(hicpp-use-auto, 3.0)
+FAST(hicpp-noexcept-move, 1.0)
+FAST(hicpp-signed-bitwise, -0.0)
+FAST(hicpp-special-member-functions, -0.0)
+FAST(hicpp-static-assert, 2.0)
+FAST(hicpp-undelegated-constructor, 0.0)
+FAST(hicpp-uppercase-literal-suffix, 1.0)
+FAST(hicpp-use-auto, 2.0)
FAST(hicpp-use-emplace, 1.0)
-FAST(hicpp-use-equals-default, 1.0)
-FAST(hicpp-use-equals-delete, 0.0)
+FAST(hicpp-use-equals-default, 3.0)
+FAST(hicpp-use-equals-delete, 4.0)
FAST(hicpp-use-noexcept, -1.0)
-FAST(hicpp-use-nullptr, 2.0)
-FAST(hicpp-use-override, -0.0)
-FAST(hicpp-vararg, -2.0)
+FAST(hicpp-use-nullptr, 1.0)
+FAST(hicpp-use-override, 1.0)
+FAST(hicpp-vararg, 1.0)
FAST(linuxkernel-must-check-errs, 1.0)
-FAST(llvm-else-after-return, 0.0)
-FAST(llvm-header-guard, 2.0)
-FAST(llvm-include-order, 3.0)
-FAST(llvm-namespace-comment, 1.0)
-FAST(llvm-prefer-isa-or-dyn-cast-in-conditionals, 0.0)
-FAST(llvm-prefer-register-over-unsigned, 1.0)
-FAST(llvm-qualified-auto, 0.0)
-FAST(llvm-twine-local, -2.0)
-FAST(llvmlibc-callee-namespace, 2.0)
-FAST(llvmlibc-implementation-in-namespace, 2.0)
+FAST(llvm-else-after-return, 1.0)
+FAST(llvm-header-guard, 1.0)
+FAST(llvm-include-order, -1.0)
+FAST(llvm-namespace-comment, -0.0)
+FAST(llvm-prefer-isa-or-dyn-cast-in-conditionals, 1.0)
+FAST(llvm-prefer-register-over-unsigned, 0.0)
+FAST(llvm-qualified-auto, -1.0)
+FAST(llvm-twine-local, -0.0)
+FAST(llvmlibc-callee-namespace, 1.0)
+FAST(llvmlibc-implementation-in-namespace, 3.0)
+FAST(llvmlibc-inline-function-decl, -3.0)
FAST(llvmlibc-restrict-system-libc-headers, -0.0)
FAST(misc-confusable-identifiers, 1.0)
-SLOW(misc-const-correctness, 261.0)
-FAST(misc-definitions-in-headers, -1.0)
+SLOW(misc-const-correctness, 306.0)
+FAST(misc-coroutine-hostile-raii, -0.0)
+FAST(misc-definitions-in-headers, -0.0)
+SLOW(misc-header-include-cycle, 9.0)
+FAST(misc-include-cleaner, 3.0)
FAST(misc-misleading-bidirectional, -0.0)
-FAST(misc-misleading-identifier, -1.0)
-FAST(misc-misplaced-const, 1.0)
-FAST(misc-new-delete-overloads, -1.0)
-FAST(misc-no-recursion, -2.0)
+FAST(misc-misleading-identifier, -0.0)
+FAST(misc-misplaced-const, -1.0)
+FAST(misc-new-delete-overloads, 1.0)
+FAST(misc-no-recursion, -1.0)
FAST(misc-non-copyable-objects, 1.0)
FAST(misc-non-private-member-variables-in-classes, 2.0)
-FAST(misc-redundant-expression, 0.0)
-FAST(misc-static-assert, 1.0)
-FAST(misc-throw-by-value-catch-by-reference, -1.0)
-FAST(misc-unconventional-assign-operator, 1.0)
-FAST(misc-uniqueptr-reset-release, 0.0)
+FAST(misc-redundant-expression, 1.0)
+FAST(misc-static-assert, -0.0)
+FAST(misc-throw-by-value-catc...
[truncated]
|
|
(this diff isn't great news for the idea of treating new checks as slow by default :-() |
kadircet
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
(this diff isn't great news for the idea of treating new checks as slow by default :-()
Well, FWIW, i think that was the trade-off we made. Most of the checks are fast, but when a slow one sneaks in, it's really hard to notice. So by being more explicit about the checks we enable, we make sure quality stays "acceptable" at the cost of missing new checks until they're explicitly turned on.
While at it, I wonder if the list of disabled checks are useful to mention in release notes going forward. I think we should at least create bugs in llvm-project issue tracker so that the authors are aware. WDYT?
|
Given that the release branch for 18 was created, could the list be updated and backported, so that clangd-18 will contain the up-to-date fast-checks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new fast checks:
bugprone-compare-pointer-to-member-variable
bugprone-empty-catch
bugprone-inc-dec-in-conditions
bugprone-incorrect-enable-if
bugprone-multi-level-implicit-pointer-conversion
bugprone-multiple-new-in-one-expression
bugprone-non-zero-enum-to-bool-conversion
bugprone-optional-value-conversion
bugprone-standalone-empty
bugprone-switch-missing-default-case
bugprone-unique-ptr-array-mismatch
bugprone-unsafe-functions
cert-msc24-c
cert-msc33-c
cppcoreguidelines-avoid-capturing-lambda-coroutines
cppcoreguidelines-avoid-reference-coroutine-parameters
cppcoreguidelines-macro-to-enum
cppcoreguidelines-misleading-capture-default
cppcoreguidelines-missing-std-forward
cppcoreguidelines-no-suspend-with-lock
cppcoreguidelines-noexcept-destructor
cppcoreguidelines-noexcept-move-operations
cppcoreguidelines-noexcept-swap
cppcoreguidelines-rvalue-reference-param-not-moved
cppcoreguidelines-use-default-member-init
llvmlibc-inline-function-decl
misc-coroutine-hostile-raii
misc-include-cleaner
misc-use-anonymous-namespace
modernize-type-traits
modernize-use-constraints
modernize-use-std-print
performance-avoid-endl
performance-enum-size
performance-noexcept-cdestructor
performance-noexcept-swap
readability-operators-representation
readibility-reference-to-constructed-temporary
new slow checks:
misc-header-include-cycle
no checks changed between fast and slow