Skip to content

[NFC][Clang] Fix potential deref of end iterator #70193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[NFC][Clang] Fix potential deref of end iterator #70193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/include/clang/Sema/CXXFieldCollector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class CXXFieldCollector {

/// getCurFields - Pointer to array of fields added to the currently parsed
/// class.
FieldDecl **getCurFields() { return &*(Fields.end() - getCurNumFields()); }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is basically cwg232 this is ok b/c we are not doing an lvalue-to-rvalue conversion but only using it to take the address of.

CC @zygoloid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review and linked pointers!
This seems to be the case. and generated code does only the pointer arithmetic, no actual load. Closing this as this is not an issue.

btw, I like your C++ trivia on twitter 😊

FieldDecl **getCurFields() { return Fields.end() - getCurNumFields(); }

/// FinishClass - Called by Sema::ActOnFinishCXXClassDef.
void FinishClass() {
Expand Down