[SVE] Fix incorrect offset calculation when rewriting an instruction's frame index. #70315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulwalker-arm
force-pushed
the
sve-stack-corruption
branch
from
a32aba9
to
3134ca7
Compare
|
|
||
| name: fp_relative_that_is_not_a_multiple_of_VLx16 | ||
| stack: | ||
| - { id: 0, stack-id: scalable-vector, size: 50, alignment: 2 } |
There was a problem hiding this comment.
The test can be simplified to have a single object, rather than multiple. Additionally, the extending part of the load makes the test even more confusing because mul vl means mul vscale x 2 x 4 bytes instead of mul vscale x 4 x 4 bytes.
Maybe you can simplify this test to:
stack:
- { id: 0, stack-id: scalable-vector, size: 156, alignment: 1 }
- { id: 1, stack-id: default, type: variable-sized, alignment: 1 }
...
renamable $z0 = LD1W_IMM killed renamable $p0, %stack.0, 0
where 156 is calculated as (8 x 16) + (14 x 2) bytes. I checked that this still exposes the original issue this patch intends to fix.
There was a problem hiding this comment.
Thanks @sdesmalen-arm , I've simplified the test case as suggested.
paulwalker-arm
force-pushed
the
sve-stack-corruption
branch
from
3134ca7
to
8b58ad2
Compare
sdesmalen-arm
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When partially packing an offset into an SVE load/store instruction we are incorrectly calculating the remainder.