[clang] Add support for new loop attribute [[clang::code_align()]] #70762

smanna12 · 2023-10-31T04:42:30Z

This patch adds support for new loop attribute: [[clang::code_align(N)]].
This attribute applies to a loop and specifies the byte alignment for a loop.
The attribute accepts a positive integer constant initialization expression
indicating the number of bytes for the minimum alignment boundary.
Its value must be a power of 2, between 1 and 4096 (inclusive).

AaronBallman

Please be sure to add a reasonable description to the patch summary so that reviewers know more about what's going on, but thank you for already having written docs (that helps give context).

The changes should come with a release note as well.

clang/include/clang/Basic/Attr.td

clang/include/clang/Basic/AttrDocs.td

clang/include/clang/Basic/DiagnosticSemaKinds.td

clang/lib/CodeGen/CGLoopInfo.cpp

clang/lib/Sema/SemaStmtAttr.cpp

clang/include/clang/Basic/Attr.td

clang/include/clang/Basic/AttrDocs.td

clang/test/Sema/code_align.c

clang/lib/CodeGen/CGLoopInfo.cpp

clang/include/clang/Basic/AttrDocs.td

clang/lib/CodeGen/CGLoopInfo.cpp

clang/lib/Sema/SemaStmtAttr.cpp

github-actions · 2023-11-02T03:37:11Z

✅ With the latest revision this PR passed the C/C++ code formatter.

smanna12 · 2023-11-02T03:38:08Z

Thank you @erichkeane and @AaronBallman for reviews and feedbacks.

Please be sure to add a reasonable description to the patch summary so that reviewers know more about what's going on, but thank you for already having written docs (that helps give context).

I have added description to the patch summary.

The changes should come with a release note as well.
Sure, I will add a release note.

I have added release note.

… Loops. This patch added backend consumption on a new loop metadata: !1 = !{!"llvm.loop.align", i32 64} which is generated from clang's new loop attribute: [[clang::code_align()]] clang patch: llvm#70762

AaronBallman

Thank you for the link to the LLVM side of things, that helps!

clang/lib/Sema/SemaStmtAttr.cpp

clang/test/Sema/code_align.c

clang/include/clang/Basic/DiagnosticSemaKinds.td

clang/lib/CodeGen/CGLoopInfo.cpp

clang/lib/Sema/SemaStmtAttr.cpp

smanna12 · 2023-11-08T02:50:15Z

@AaronBallman, @erichkeane I have addressed comments in the PR, could you please revisit this PR? Thank you!

clang/test/Sema/code_align.c

smanna12 · 2023-11-20T18:25:07Z

Thank you @erichkeane for reviews!

… Loops. (#71026) This patch added backend consumption on a new loop metadata: !1 = !{!"llvm.loop.align", i32 64} which is generated from clang's new loop attribute: [[clang::code_align()]] clang patch: #70762

This patch disables parts of clang/test/Sema/code_align.c that need __int128_t to be defined. This will fix failures on Arm v7 buildbots due to #70762 Following bots are failing: https://lab.llvm.org/buildbot/#/builders/245 https://lab.llvm.org/buildbot/#/builders/178 https://lab.llvm.org/buildbot/#/builders/182 https://lab.llvm.org/buildbot/#/builders/186 https://lab.llvm.org/buildbot/#/builders/187

Lit test generates different outputs for usage of __int128_t in clang-armv8-quick environment. This patch adds triple to fix the lit failure. ``` Step 5 (ninja check 1) failure: 1 unexpected failures 38623 expected passes 71 expected failures 36752 unsupported tests (failure) ******************** TEST 'Clang :: Sema/code_align.c' FAILED ******************** Exit Code: 1 Command Output (stderr): -- RUN: at line 1: /home/tcwg-buildbot/worker/clang-armv8-quick/stage1/bin/clang -cc1 -internal-isystem /home/tcwg-buildbot/worker/clang-armv8-quick/stage1/lib/clang/18/include -nostdsysteminc -fsyntax-only -verify=expected,c-local -x c /home/tcwg-buildbot/worker/clang-armv8-quick/llvm/clang/test/Sema/code_align.c + /home/tcwg-buildbot/worker/clang-armv8-quick/stage1/bin/clang -cc1 + -internal-isystem + /home/tcwg-buildbot/worker/clang-armv8-quick/stage1/lib/clang/18/inclu + de -nostdsysteminc -fsyntax-only -verify=expected,c-local -x c + /home/tcwg-buildbot/worker/clang-armv8-quick/llvm/clang/test/Sema/code + _align.c error: 'c-local-error' diagnostics expected but not seen: File /home/tcwg-buildbot/worker/clang-armv8-quick/llvm/clang/test/Sema/code_align.c Line 79 (directive at /home/tcwg-buildbot/worker/clang-armv8-quick/llvm/clang/test/Sema/code_align.c:78): 'code_align' attribute requires an integer argument which is a constant power of two between 1 and 4096 inclusive; provided argument was (__int128_t)1311768467294899680ULL << 64 File /home/tcwg-buildbot/worker/clang-armv8-quick/llvm/clang/test/Sema/code_align.c Line 89 (directive at /home/tcwg-buildbot/worker/clang-armv8-quick/llvm/clang/test/Sema/code_align.c:88): 'code_align' attribute requires an integer argument which is a constant power of two between 1 and 4096 inclusive; provided argument was -(__int128_t)1311768467294899680ULL << 64 error: 'c-local-error' diagnostics seen but not expected: File /home/tcwg-buildbot/worker/clang-armv8-quick/llvm/clang/test/Sema/code_align.c Line 79: use of undeclared identifier '__int128_t' File /home/tcwg-buildbot/worker/clang-armv8-quick/llvm/clang/test/Sema/code_align.c Line 89: use of undeclared identifier '__int128_t' 4 errors generated. ```

…e way we handle conflicting vs duplicate values This patch diagnose non-identical duplicates as a 'conflicting' loop attributes and suppress duplicate errors in cases where the two match for FPGA SYCL attributes: 'SYCLIntelMaxInterleavingAttr', 'SYCLIntelSpeculatedIterationsAttr', and 'SYCLIntelMaxReinvocationDelayAttr' to align with clang community change (Ref: llvm/llvm-project#70762). Signed-off-by: Soumi Manna <soumi.manna@intel.com>

…e way we handle conflicting vs duplicate values (#12243) This patch diagnose non-identical duplicates as a 'conflicting' loop attributes and suppress duplicate errors in cases where the two match for FPGA SYCL attributes: 'SYCLIntelMaxInterleavingAttr', 'SYCLIntelSpeculatedIterationsAttr', and 'SYCLIntelMaxReinvocationDelayAttr' to align with clang community change (Ref: llvm/llvm-project#70762). --------- Signed-off-by: Soumi Manna <soumi.manna@intel.com>

MaskRay · 2024-02-06T03:35:30Z

@efriedma-quic

(came here from #80765)

…e way we handle conflicting vs duplicate values This patch updates ExprArgument<> to use same routine CheckForDuplicateAttrs() that was added on intel#12243 to diagnose non-identical duplicates as a 'conflicting' loop attributes and suppresse duplicate errors in cases where the two match for FPGA SYCL attributes: [[intel::max_concurrency()]] and [[intel::initiation_interval()]] to align with clang community change (Ref: llvm/llvm-project#70762). Signed-off-by: Soumi Manna <soumi.manna@intel.com>

…e way we handle conflicting vs duplicate values (#13146) This patch updates ExprArgument<> to use same routine CheckForDuplicateAttrs() that was added on #12243 to diagnose non-identical duplicates as a 'conflicting' loop attributes and suppresse duplicate errors in cases where the two match for FPGA SYCL attributes: [[intel::max_concurrency()]] and [[intel::initiation_interval()]] to align with clang community change (Ref: llvm/llvm-project#70762). --------- Signed-off-by: Soumi Manna <soumi.manna@intel.com>

…h loop attribute 'code_align' llvm#70762 added support for new loop attribute [[clang::code_align()]]. This patch fixes bug for the test case below that misses diagnostic due to discontinue to loop while checking duplicate vs conflicting code_align attribute values. [[clang::code_align(4)]] [[clang::code_align(4)]] [[clang::code_align(8)]] for(int I=0; I<128; ++I) { bar(I); }

…th loop attribute 'code_align' (#87372) #70762 added support for new loop attribute [[clang::code_align()]]. This patch fixes bugs for the test cases below that misses diagnostics due to discontinue to while loop during checking duplicate vs conflicting code_align attribute values in routine CheckForDuplicateLoopAttrs(). [[clang::code_align(4)]] [[clang::code_align(4)]] [[clang::code_align(8)]] for(int I=0; I<128; ++I) { bar(I); } [[clang::code_align(4)]] [[clang::code_align(4)]] [[clang::code_align(8)]] [[clang::code_align(32)]] for(int I=0; I<128; ++I) { bar(I); }

[clang] Add support for new loop attribute [[clang::code_align()]]

93d46d4

llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:codegen labels Oct 31, 2023

smanna12 requested review from mikerice1969, AaronBallman and FreddyLeaf October 31, 2023 04:51

AaronBallman reviewed Nov 1, 2023

View reviewed changes

AaronBallman requested a review from erichkeane November 1, 2023 17:01

erichkeane reviewed Nov 1, 2023

View reviewed changes

Address review comments

d049dc9

Fix clang format errors

6c44cc1

FreddyLeaf mentioned this pull request Nov 2, 2023

[MachineBlockPlacement][X86] Use max of MDAlign and TLIAlign to align Loops. #71026

Merged

Fix Lit test failure

f35c4be

AaronBallman reviewed Nov 2, 2023

View reviewed changes

clang/lib/Sema/SemaStmtAttr.cpp Outdated Show resolved Hide resolved

clang/test/Sema/code_align.c Outdated Show resolved Hide resolved

clang/include/clang/Basic/DiagnosticSemaKinds.td Outdated Show resolved Hide resolved

smanna12 added 2 commits November 6, 2023 09:30

Address review comments

4c40ce2

Fix clang format errors

9144e44

AaronBallman reviewed Nov 6, 2023

View reviewed changes

clang/include/clang/Basic/DiagnosticSemaKinds.td Outdated Show resolved Hide resolved

clang/lib/CodeGen/CGLoopInfo.cpp Outdated Show resolved Hide resolved

clang/lib/Sema/SemaStmtAttr.cpp Outdated Show resolved Hide resolved

clang/lib/Sema/SemaStmtAttr.cpp Outdated Show resolved Hide resolved

smanna12 added 5 commits November 6, 2023 11:56

Address review comments

22f66bd

Fix lit test failure

66f6269

Fix DuplicateCodeAlignAttrs check

3ac064b

Fix Clang format errors

172e238

Remove wrong function

c8d5270

smanna12 requested review from AaronBallman and erichkeane November 7, 2023 05:18

Merge remote-tracking branch 'my_remote/main' into AddCodeAlignAttr

d16a0f9

Address review comments

f32df3f

erichkeane reviewed Nov 17, 2023

View reviewed changes

clang/test/Sema/code_align.c Outdated Show resolved Hide resolved

smanna12 added 2 commits November 17, 2023 12:23

Fix clang format errors

d5ee5c1

Fix diagnostic issues with conflicting attributes for template cases

6778154

erichkeane approved these changes Nov 20, 2023

View reviewed changes

Fix clang format errors

886c03a

smanna12 merged commit 48ff354 into llvm:main Nov 20, 2023
4 checks passed

smanna12 deleted the AddCodeAlignAttr branch November 20, 2023 22:13

smanna12 added a commit to smanna12/llvm-project that referenced this pull request Nov 21, 2023

[clang] Fix lit test failure caused by llvm#70762

55d5f22

kwk mentioned this pull request Nov 21, 2023

Broken snapshot for 20231121 detected fedora-llvm-team/llvm-snapshots#111

Closed

smanna12 mentioned this pull request Dec 24, 2023

[SYCL][FPGA] Refactor statments attributes to align with community the way we handle conflicting vs duplicate values intel/llvm#12243

Merged

smanna12 mentioned this pull request Mar 25, 2024

[SYCL][FPGA] Refactor statments attributes to align with community the way we handle conflicting vs duplicate values intel/llvm#13146

Merged

smanna12 mentioned this pull request Apr 2, 2024

[Clang] Fix bug the way we handle duplicate vs conflicting values with loop attribute 'code_align' #87372

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[clang] Add support for new loop attribute [[clang::code_align()]] #70762

[clang] Add support for new loop attribute [[clang::code_align()]] #70762

smanna12 commented Oct 31, 2023 •

edited

Loading

AaronBallman left a comment

github-actions bot commented Nov 2, 2023 •

edited

Loading

smanna12 commented Nov 2, 2023 •

edited

Loading

AaronBallman left a comment

smanna12 commented Nov 8, 2023 •

edited

Loading

smanna12 commented Nov 20, 2023

MaskRay commented Feb 6, 2024 •

edited

Loading

[clang] Add support for new loop attribute [[clang::code_align()]] #70762

[clang] Add support for new loop attribute [[clang::code_align()]] #70762

Conversation

smanna12 commented Oct 31, 2023 • edited Loading

AaronBallman left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 2, 2023 • edited Loading

smanna12 commented Nov 2, 2023 • edited Loading

AaronBallman left a comment

Choose a reason for hiding this comment

smanna12 commented Nov 8, 2023 • edited Loading

smanna12 commented Nov 20, 2023

MaskRay commented Feb 6, 2024 • edited Loading

smanna12 commented Oct 31, 2023 •

edited

Loading

github-actions bot commented Nov 2, 2023 •

edited

Loading

smanna12 commented Nov 2, 2023 •

edited

Loading

smanna12 commented Nov 8, 2023 •

edited

Loading

MaskRay commented Feb 6, 2024 •

edited

Loading