Report pass name when -llvm-verify-each reports breakage #71447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the string reported to include the pass name of last pass when running verifier after each pass.
|
@aeubanks Can you be a reviewer for this PR? Thanks. |
|
code looks good, but I'd like a test like how we test -print-on-crash with we should have a module pass and a function pass that intentionally break the IR, then run those in the test |
|
Thanks for the suggestion on testing. I wasn't sure how to create a test that was intended to crash. Let me look into the tests you mention. |
Adds a testing pass that intentionally creates IR that will trigger a verification failure to test that -verify-each generates an appropriate error message.
aeubanks
approved these changes
Nov 30, 2023
llvm/lib/Passes/PassBuilder.cpp
Outdated
|
|
||
| // A pass for testing message reporting of -verify-each failures. | ||
| // DO NOT USE THIS EXCEPT FOR TESTING! | ||
| class TriggerVerifyEachFailurePass |
There was a problem hiding this comment.
I'd rename this to TriggerVerifierErrorPass/trigger-verifier-error
There was a problem hiding this comment.
Sounds good. I'll update it.
|
thanks! |
|
@aeubanks Thanks for merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the string reported to include the pass name of last pass when running verifier after each pass.