Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Instructions for new contributors to find reviewers #71936

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

pabloantoniom
Copy link
Contributor

Right now, the documentation does not clarify what new contributors should do to find potential reviewers, since new contributors don't have write access and thus cannot select them as explained in the docs.

This patch extends the guidelines for new people, as discussed in https://discourse.llvm.org/t/how-to-find-reviewers/74803

cc: @kbeyls @DavidSpickett

Copy link
Collaborator

@kbeyls kbeyls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

I guess you may want me to merge this PR for you as you may not yet have merge rights?

@pabloantoniom
Copy link
Contributor Author

LGTM, thank you!

I guess you may want me to merge this PR for you as you may not yet have merge rights?

Yes please! I don't see any merge button, so I guess I don't have merge rights

@kbeyls kbeyls merged commit beb121f into llvm:main Nov 10, 2023
4 checks passed
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
Right now, the documentation does not clarify what new contributors
should do to find potential reviewers, since new contributors don't have
write access and thus cannot select them as explained in the docs.

This patch extends the guidelines for new people, as discussed in
https://discourse.llvm.org/t/how-to-find-reviewers/74803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants