Skip to content

[libc++] <experimental/simd> Reduce compilation time of reference assignment test #72632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[libc++] <experimental/simd> Reduce compilation time of reference assignment test #72632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions libcxx/test/std/experimental/simd/simd.reference/reference_assignment.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,9 @@ struct CheckSimdReferenceAssignmentHelper {
void operator()() const {
if constexpr (std::is_assignable_v<T&, U&&>) {
ex::simd<T, SimdAbi> origin_simd([](T i) { return i; });
for (size_t i = 0; i < origin_simd.size(); ++i) {
static_assert(noexcept(origin_simd[i] = static_cast<U>(i + 1)));
origin_simd[i] = static_cast<U>(i + 1);
assert(origin_simd[i] == static_cast<T>(std::forward<U>(i + 1)));
}
static_assert(noexcept(origin_simd[0] = static_cast<U>(5)));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this actually reduces the compilation time since there's no additional instantiations being performed here. This is just code running at runtime, and the runtime of the test is not the issue. Did I miss something?

origin_simd[0] = static_cast<U>(5);
assert(origin_simd[0] == static_cast<T>(std::forward<U>(5)));
}
}
};
Expand All @@ -44,11 +42,9 @@ struct CheckMaskReferenceAssignmentHelper {
void operator()() const {
if constexpr (std::is_assignable_v<bool&, U&&>) {
ex::simd_mask<T, SimdAbi> origin_mask(true);
for (size_t i = 0; i < origin_mask.size(); ++i) {
static_assert(noexcept(origin_mask[i] = static_cast<U>(i + 1)));
origin_mask[i] = static_cast<U>(i % 2);
assert(origin_mask[i] == static_cast<T>(std::forward<U>(i % 2)));
}
static_assert(noexcept(origin_mask[0] = false));
origin_mask[0] = false;
assert(origin_mask[0] == false);
}
}
};
Expand Down